public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH RFC i-g-t] tests/kms_chamelium: disable output when resetting state
Date: Thu, 11 Jul 2019 14:11:40 +0300	[thread overview]
Message-ID: <20190711111140.7840-1-simon.ser@intel.com> (raw)

Quoting Imre from the bug comments:

> If unplugging a DP-alt display while there is an active modeset on it, and
> then replugging the DP-alt display, the HW/FW/driver won't signal the
> corresponding plug-in hotplug event until the mode is disabled.
>
> The failing tests do this:
>
> - <have the output enabled>
> - unplug the display, keeping the output enabled
> - wait/poll for the disconnect status -> success
> - replug the display, while the output is still enabled
> - wait/poll for the connect status -> fail
>
> This sequence is not supported with DP-alt sinks (like the USB-C to HDMI
> dongle), as I described above.

This patch changes reset_state to disable the output before unplugging the
connector (via chamelium_reset).

Signed-off-by: Simon Ser <simon.ser@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111045
---

This is just a RFC to check that the root issue is what we think it is.

 tests/kms_chamelium.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index b749b5598c1d..f538ad394480 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -216,6 +216,13 @@ static void
 reset_state(data_t *data, struct chamelium_port *port)
 {
 	int p;
+	drmModeConnector *connector;
+	igt_output_t *output;
+
+	connector = chamelium_port_get_connector(data->chamelium, port, false);
+	output = igt_output_from_connector(&data->display, connector);
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);

 	chamelium_reset(data->chamelium);

--
2.22.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-07-11 11:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 11:11 Simon Ser [this message]
2019-07-11 12:40 ` [igt-dev] [PATCH RFC i-g-t] tests/kms_chamelium: disable output when resetting state Daniel Vetter
2019-07-11 12:47   ` Ser, Simon
2019-07-11 13:14     ` Daniel Vetter
2019-07-12 13:12       ` Imre Deak
2019-07-15  9:33         ` Daniel Vetter
2019-08-14 14:04       ` Ser, Simon
2019-08-14 12:27   ` Ser, Simon
2019-08-14 12:28     ` Ser, Simon
2019-07-11 15:41 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190711111140.7840-1-simon.ser@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox