From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/4] lib/igt_edid: make HDMI VSDB data array unsigned
Date: Fri, 19 Jul 2019 14:38:46 +0300 [thread overview]
Message-ID: <20190719113847.32626-4-simon.ser@intel.com> (raw)
In-Reply-To: <20190719113847.32626-1-simon.ser@intel.com>
This array is filled manually, some bytes might have the MSB set.
This fixes the following warning:
../lib/igt_kms.c:357:18: warning: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Wconstant-conversion]
hdmi->data[0] = HDMI_VSDB_VIDEO_3D_PRESENT; /* HDMI video flags */
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
lib/igt_edid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_edid.h b/lib/igt_edid.h
index 319ccc3dc734..d256b7896c90 100644
--- a/lib/igt_edid.h
+++ b/lib/igt_edid.h
@@ -238,7 +238,7 @@ struct hdmi_vsdb {
uint8_t flags1; /* enum hdmi_vsdb_flags1 */
uint8_t max_tdms_clock; /* multiply by 5MHz */
uint8_t flags2; /* enum hdmi_vsdb_flags2 */
- char data[]; /* latency, misc, VIC, 3D */
+ uint8_t data[]; /* latency, misc, VIC, 3D */
} __attribute__((packed));
#define HDMI_VSDB_MIN_SIZE 2 /* just the source physical address */
--
2.22.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-07-19 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser
2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: use struct edid instead of unsigned char Simon Ser
2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_kms: drop EDID_LENGTH, replace with EDID_BLOCK_SIZE Simon Ser
2019-07-19 11:38 ` Simon Ser [this message]
2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_edid: merge edid_ext_update_cea_checksum into edid_update_checksum Simon Ser
2019-07-19 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements Patchwork
2019-07-19 12:13 ` Ser, Simon
2019-07-19 13:49 ` Martin Peres
2019-07-19 14:26 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-07-19 17:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-08-15 8:25 ` [igt-dev] [PATCH i-g-t 0/4] " Arkadiusz Hiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719113847.32626-4-simon.ser@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox