From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/i915_pm_sseu: Don't try to get enabled subslices if it's not there
Date: Wed, 24 Jul 2019 11:38:34 +0300 [thread overview]
Message-ID: <20190724083834.5105-1-arkadiusz.hiler@intel.com> (raw)
The debugfs contains "Enabled SliceX subslices:" line only if a given
slice is enabled. If we try to dbg_get_status() with everything shut
down we will get a confusing assertion failure:
CRITICAL: Test assertion failure function dbg_get_int, file ../tests/i915/i915_pm_sseu.c:120:
CRITICAL: Failed assertion: pos != NULL
To fix that let's just read the enabled subslices if the line is there,
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110593
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/i915/i915_pm_sseu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/i915_pm_sseu.c b/tests/i915/i915_pm_sseu.c
index 252df7d3..0b936982 100644
--- a/tests/i915/i915_pm_sseu.c
+++ b/tests/i915/i915_pm_sseu.c
@@ -199,7 +199,7 @@ dbg_get_status(struct status *stat)
if (dbg_has_line(first, last, "Enabled Subslice Per Slice:")) {
stat->hw.subslice_per =
dbg_get_int(first, last, "Enabled Subslice Per Slice:");
- } else {
+ } else if (dbg_has_line(first, last, "Enabled Slice0 subslices:")) {
stat->hw.subslice_per =
dbg_get_int(first, last, "Enabled Slice0 subslices:");
}
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-07-24 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:38 Arkadiusz Hiler [this message]
2019-07-24 8:49 ` [igt-dev] [PATCH i-g-t] tests/i915_pm_sseu: Don't try to get enabled subslices if it's not there Lionel Landwerlin
2019-07-24 8:53 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2019-07-24 9:10 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-07-24 12:28 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-07-25 12:42 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724083834.5105-1-arkadiusz.hiler@intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox