From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: stanislav.lisovskiy@intel.com, ville.syrjala@intel.com,
martin.peres@intel.com
Subject: [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk
Date: Mon, 29 Jul 2019 17:15:11 +0300 [thread overview]
Message-ID: <20190729141511.9360-1-stanislav.lisovskiy@intel.com> (raw)
While doing some gpu fill based tests, noticed that
actually the x and y parameters do not affect the
filled area at all.
After short study looks like gen8_gpgpu_walk was not
using those at all.
Started using those according to bspec, so now it is
actually possible to use initial x and y values.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
lib/gpu_cmds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 8d270ee8..48ddfa0c 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -681,12 +681,12 @@ gen8_emit_gpgpu_walk(struct intel_batchbuffer *batch,
0); /* width:1 */
/* thread group X */
- OUT_BATCH(0);
+ OUT_BATCH(x);
OUT_BATCH(0);
OUT_BATCH(x_dim);
/* thread group Y */
- OUT_BATCH(0);
+ OUT_BATCH(y);
OUT_BATCH(0);
OUT_BATCH(y_dim);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-07-29 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 14:15 Stanislav Lisovskiy [this message]
2019-07-29 16:22 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/lib: Start using x and y params for gpu walk Patchwork
2019-07-29 17:01 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2019-07-30 1:14 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2019-08-07 8:36 ` [igt-dev] [PATCH i-g-t v1] " Lisovskiy, Stanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729141511.9360-1-stanislav.lisovskiy@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox