Re: [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk

Lisovskiy, Stanislav
2019-08-07T08:36:06Z

On Mon, 2019-07-29 at 17:15 +0300, Stanislav Lisovskiy wrote:
> While doing some gpu fill based tests, noticed that
> actually the x and y parameters do not affect the
> filled area at all.
> After short study looks like gen8_gpgpu_walk was not
> using those at all.
> Started using those according to bspec, so now it is
> actually possible to use initial x and y values.
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> lib/gpu_cmds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
> index 8d270ee8..48ddfa0c 100644
> --- a/lib/gpu_cmds.c
> +++ b/lib/gpu_cmds.c
> @@ -681,12 +681,12 @@ gen8_emit_gpgpu_walk(struct intel_batchbuffer
> *batch,
> 0); /* width:1 */
>
> /* thread group X */
> - OUT_BATCH(0);
> + OUT_BATCH(x);
> OUT_BATCH(0);
> OUT_BATCH(x_dim);
>
> /* thread group Y */
> - OUT_BATCH(0);
> + OUT_BATCH(y);
> OUT_BATCH(0);
> OUT_BATCH(y_dim);
>

Chris, could you please have a look if this is correct?

Probably we also need to add this for other platforms,
I was just implementing a stress test case where I wanted to use
shader to fill some specific part of frame buffer and then figured
out that x and y parameters are not used.

Best Regards,

Lisovskiy Stanislav