From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B0786E5FC for ; Tue, 30 Jul 2019 19:22:29 +0000 (UTC) Date: Tue, 30 Jul 2019 12:24:00 -0700 From: Manasi Navare Message-ID: <20190730192400.GB2736@intel.com> References: <20190717181055.581-1-madhumitha.tolakanahalli.pradeep@intel.com> <6a7512c12f04cb23827f6d19536409b2359a7eb7.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a7512c12f04cb23827f6d19536409b2359a7eb7.camel@intel.com> Subject: Re: [igt-dev] [PATCH] lib/igt_kms.c igt_kms.h: tile property parser List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Ser, Simon" Cc: "igt-dev@lists.freedesktop.org" , "Latvala, Petri" List-ID: T24gV2VkLCBKdWwgMTcsIDIwMTkgYXQgMTE6MjQ6MzNQTSAtMDcwMCwgU2VyLCBTaW1vbiB3cm90 ZToKPiBIaSwKPiAKPiBIZXJlIGFyZSBhIGZldyBjb21tZW50cy4KPiAKPiBPbiBXZWQsIDIwMTkt MDctMTcgYXQgMTE6MTAgLTA3MDAsIE1hZGh1bWl0aGEgVG9sYWthbmFoYWxsaSBQcmFkZWVwIHdy b3RlOgo+ID4gVGhlIHRpbGUgcHJvcGVydHkgcGFyc2VyIHBhcnNlcyB0aGUgY29ubmVjdG9yIHRp bGUgcHJvcGVydHkgb2J0YWluZWQKPiA+IGZyb20gY29ubmVjdG9yJ3MgRGlzcGxheSBJRCBibG9j ayBhbmQgc2V0IHBlciBjb25uZWN0b3IuCj4gPiAKPiA+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5h c2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gQ2M6IFBldHJpIExhdHZhbGEgPHBldHJpLmxhdHZh bGFAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogTWFkaHVtaXRoYSBUb2xha2FuYWhhbGxp IFByYWRlZXAgPG1hZGh1bWl0aGEudG9sYWthbmFoYWxsaS5wcmFkZWVwQGludGVsLmNvbT4KPiA+ IC0tLQo+ID4gIGxpYi9pZ3Rfa21zLmMgfCAyNiArKysrKysrKysrKysrKysrKysrKysrKysrKwo+ ID4gIGxpYi9pZ3Rfa21zLmggfCAxMSArKysrKysrKysrKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwg MzcgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuYyBiL2xp Yi9pZ3Rfa21zLmMKPiA+IGluZGV4IDE3NWU3MWMzLi44NDYzMTRkZSAxMDA2NDQKPiA+IC0tLSBh L2xpYi9pZ3Rfa21zLmMKPiA+ICsrKyBiL2xpYi9pZ3Rfa21zLmMKPiA+IEBAIC00NTExLDMgKzQ1 MTEsMjkgQEAgYm9vbCBpZ3RfZGlzcGxheV9oYXNfZm9ybWF0X21vZChpZ3RfZGlzcGxheV90ICpk aXNwbGF5LCB1aW50MzJfdCBmb3JtYXQsCj4gPiAgCj4gPiAgCXJldHVybiBmYWxzZTsKPiA+ICB9 Cj4gPiArCj4gPiArLyoqCj4gPiArICogaWd0X3BhcnNlX2Nvbm5lY3Rvcl90aWxlX2Jsb2I6Cj4g PiArICogQGJsb2I6IHBvaW50ZXIgdG8gdGhlIGNvbm5lY3RvcidzIHRpbGUgcHJvcGVydGllcwo+ ID4gKyAqIEB0aWxlOiBwb2ludGVyIHRvIHRpbGUgc3RydWN0dXJlIHRoYXQgaXMgcG9wdWxhdGVk IGJ5IHRoZSBmdW5jdGlvbgo+ID4gKyAqCj4gPiArICogUGFyc2VzIHRoZSBjb25uZWN0b3IgdGls ZSBibG9iIHRvIGV4dHJhY3QgdGhlIHRpbGUgaW5mb3JtYXRpb24KPiA+ICsgKgo+ID4gKyAqLwo+ ID4gKwo+ID4gK3ZvaWQgaWd0X3BhcnNlX2Nvbm5lY3Rvcl90aWxlX2Jsb2IoZHJtTW9kZVByb3Bl cnR5QmxvYlB0ciBibG9iLAo+ID4gKwkJCQlpZ3RfdGlsZV9pbmZvX3QgKiB0aWxlKQo+IAo+IFN0 eWxlOiBhbGlnbiB3aXRoIGFzIG1hbnkgdGFicyBhcyBwb3NzaWJsZSwgdGhlbiBmaWxsIHRoZSBy ZXN0IHdpdGgKPiBzcGFjZXMuCj4gCj4gPiArewo+ID4gKwljaGFyICogYmxvYl9kYXRhID0gYmxv Yi0+ZGF0YTsKPiAKPiBTdHlsZTogbm8gc3BhY2UgYWZ0ZXIgc3Rhci4KPiAKPiAgICAgY2hhciAq dGhpbmcgPSBzdHVmZjsKPiAKPiBBcHBsaWVzIHRvIHRoZSB3aG9sZSBwYXRjaC4KPiAKPiA+ICsJ aWYoYmxvYikgewo+IAo+IFN0eWxlOiBzcGFjZSBhZnRlciBpZiBrZXl3b3JkLgo+IAo+ID4gKwkJ dGlsZS0+dGlsZV9ncm91cF9pZCA9IGF0b2koc3RydG9rKGJsb2JfZGF0YSwgIjoiKSk7Cj4gCj4g VGhpcyBzZWdmYXVsdHMgaWYgdGhlIGZpZWxkIGRvZXNuJ3QgZXhpc3QuIEl0IHdvdWxkIGJlIG5p Y2VyIHRvCj4gaWd0X2Fzc2VydCB0aGF0IHN0cnRvayBkb2Vzbid0IHJldHVybiBOVUxMLiBNYXli ZSB3aXRoIGEgd3JhcHBlcgo+IGZ1bmN0aW9uPyBlLmcuCj4gCj4gICAgIHN0YXRpYyBpbnQgcGFy c2VfbmV4dF90aWxlX2ZpZWxkKGNoYXIgKmRhdGEpCj4gCj4gQWxzbyB0aGlzIGRvZXNuJ3QgY2hl Y2sgZm9yIGludGVnZXIgb3ZlcmZsb3dzLCBidXQgbm90IHN1cmUgaXQncyB3b3J0aAo+IHRoZSBo YXNzbGUuCj4gCj4gPiArCQl0aWxlLT50aWxlX2lzX3NpbmdsZV9tb25pdG9yID0gYXRvaShzdHJ0 b2soTlVMTCwgIjoiKSk7Cj4gPiArCQl0aWxlLT5udW1faF90aWxlID0gYXRvaShzdHJ0b2soTlVM TCwgIjoiKSk7Cj4gPiArCQl0aWxlLT5udW1fdl90aWxlID0gYXRvaShzdHJ0b2soTlVMTCwgIjoi KSk7Cj4gPiArCQl0aWxlLT50aWxlX2hfbG9jID0gYXRvaShzdHJ0b2soTlVMTCwgIjoiKSk7Cj4g PiArCQl0aWxlLT50aWxlX3ZfbG9jID0gYXRvaShzdHJ0b2soTlVMTCwgIjoiKSk7Cj4gPiArCQl0 aWxlLT50aWxlX2hfc2l6ZSA9IGF0b2koc3RydG9rKE5VTEwsICI6IikpOwo+ID4gKwkJdGlsZS0+ dGlsZV92X3NpemUgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsKPiA+ICsJfQo+ID4gK30KPiA+ IGRpZmYgLS1naXQgYS9saWIvaWd0X2ttcy5oIGIvbGliL2lndF9rbXMuaAo+ID4gaW5kZXggMDQ4 NjczN2IuLjA4NDgzNTA1IDEwMDY0NAo+ID4gLS0tIGEvbGliL2lndF9rbXMuaAo+ID4gKysrIGIv bGliL2lndF9rbXMuaAo+ID4gQEAgLTM4Nyw2ICszODcsMTQgQEAgc3RydWN0IGlndF9kaXNwbGF5 IHsKPiA+ICAJaW50IGZvcm1hdF9tb2RfY291bnQ7Cj4gPiAgfTsKPiA+ICAKPiA+ICt0eXBlZGVm IHN0cnVjdCB7Cj4gPiArCWludCB0aWxlX2dyb3VwX2lkOwo+ID4gKwlib29sIHRpbGVfaXNfc2lu Z2xlX21vbml0b3I7Cj4gPiArCXVpbnQ4X3QgbnVtX2hfdGlsZSwgbnVtX3ZfdGlsZTsKPiA+ICsJ dWludDhfdCB0aWxlX2hfbG9jLCB0aWxlX3ZfbG9jOwo+ID4gKwl1aW50MTZfdCB0aWxlX2hfc2l6 ZSwgdGlsZV92X3NpemU7Cj4gCj4gSSB3b3VsZG4ndCByZXBlYXQgdGhlIHRpbGVfIHByZWZpeCBm b3IgYWxsIG9mIHRoZXNlIGZpZWxkcywgaXQncwo+IGFscmVhZHkgY2xlYXIgdGhhdCBpdCdzIGFi b3V0IHRoZSB0aWxlIGZyb20gdGhlIHR5cGUgbmFtZS4KClRoZSBpZGVhIG9mIHVzaW5nIHRpbGVf IHByZWZpeCBpcyBzbyB0aGF0IGl0IGFsaWducyB3aXRoIHRoZSB0aWxlIGZpZWxkcyBpbiB0aGUK a2VybmVsIGFuZCB0aGVzZSBhcmUgdGhlIGV4YWN0IG5hbWVzIHRoYXQgZ2V0IHByaW50ZWQgaW4g dGhlIGRtZXNnIHNvIG1ha2VzCml0IG1vcmUgaW50dWl0aXZlIGlmIHdlIHN0aWNrIHRvIHRoZXNl IG5hbWVzLgoKTWFuYXNpCgo+IAo+ID4gK30gaWd0X3RpbGVfaW5mb190Owo+IAo+IEknbSBwZXJz b25hbGx5IG5vdCBhIGZhbiBvZiB0eXBlZGVmcywgYnV0IGl0IHNlZW1zIGxpa2UgdGhlIHJlc3Qg b2YgSUdUCj4gZG9lc24ndCBjYXJlLCBzbyBpdCdzIHByb2JhYmx5IGZpbmUuCj4gCj4gPiAgdm9p ZCBpZ3RfZGlzcGxheV9yZXF1aXJlKGlndF9kaXNwbGF5X3QgKmRpc3BsYXksIGludCBkcm1fZmQp Owo+ID4gIHZvaWQgaWd0X2Rpc3BsYXlfZmluaShpZ3RfZGlzcGxheV90ICpkaXNwbGF5KTsKPiA+ ICB2b2lkIGlndF9kaXNwbGF5X3Jlc2V0KGlndF9kaXNwbGF5X3QgKmRpc3BsYXkpOwo+ID4gQEAg LTgzNSw0ICs4NDMsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaWd0X3ZibGFua19iZWZvcmUodWlu dDMyX3QgYSwgdWludDMyX3QgYikKPiA+ICAJcmV0dXJuIGlndF92YmxhbmtfYWZ0ZXIoYiwgYSk7 Cj4gPiAgfQo+ID4gIAo+ID4gK3ZvaWQgaWd0X3BhcnNlX2Nvbm5lY3Rvcl90aWxlX2Jsb2IoZHJt TW9kZVByb3BlcnR5QmxvYlB0ciBibG9iLAo+ID4gKwkJCWlndF90aWxlX2luZm9fdCAqIHRpbGUp Owo+ID4gKwo+ID4gICNlbmRpZiAvKiBfX0lHVF9LTVNfSF9fICovCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1k ZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaWd0LWRldg==