public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_properties: Fix upper bound of 'max bpc' range
Date: Thu,  8 Aug 2019 17:02:05 +0300	[thread overview]
Message-ID: <20190808140205.16658-1-imre.deak@intel.com> (raw)

The available range reported by the driver is the inclusive [min_bpc,
max_bpc], so fix the upper bound used by the test accordingly. This
issue had the side-effect (on ICL for instance) of limiting 'max bpc' to
10 (instead of restoring it to the default 12) for all the tests
following kms_properties, as seen from the logs in the referenced bug
below.

Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109593
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 tests/kms_properties.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index eb9cbdda..18cf96e0 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -91,7 +91,7 @@ static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropert
 	if (atomic)
 		req = drmModeAtomicAlloc();
 
-	for ( i = prop->values[0]; i < prop->values[1] ; i++) {
+	for (i = prop->values[0]; i <= prop->values[1]; i++) {
 		if (!atomic) {
 			ret = drmModeObjectSetProperty(fd, id, type, prop_id, i);
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-08-08 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 14:02 Imre Deak [this message]
2019-08-08 14:23 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_properties: Fix upper bound of 'max bpc' range Patchwork
2019-08-08 23:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-08-12  9:22   ` Imre Deak
2019-08-20 14:22     ` Imre Deak
2019-08-13  8:07 ` [igt-dev] [PATCH i-g-t] " Ser, Simon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190808140205.16658-1-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox