Re: [igt-dev] [PATCH v2 3/3] gitlab-ci: introduce final containers

Arkadiusz Hiler
2019-08-23T12:50:57Z

On Fri, Aug 23, 2019 at 03:41:03PM +0300, Vasilev, Oleg wrote:
> On Thu, 2019-08-22 at 11:45 +0300, Arkadiusz Hiler wrote:
> > On Tue, Aug 20, 2019 at 04:19:36PM +0300, Oleg Vasilev wrote:
> ...
> > >
> > > +############## FINAL CONTAINERS ####################
> > > +
> > > +
> > > +final-containers:igt-final:
> >
> > I am sceptical about having it named igt-final.
> >
> > How about just igt-x86_64?
> >
> > If you need further clarification on what people should use then you
> > can
> > add "build-env-" to the name of the *base* images.
> Hi,
>
> I could rename igt-final to igt and igt-* to igt-base-*. Would it break
> any preexiting automatization?

AFAIK nothing uses those containers outside of Gitlab's CI, so we should
be good.

Thinking about naming, I believe we should have more clear separation.
"igt-$(ARCH/OTHERSUFFIXES)" for the containers having IGT inside.
With that I would like to avoid using "igt" for containers without IGT.

So what about:

builder-fedora
builder-debian
builder-debian-mips
...?

--
Cheers,
Arek