Re: [igt-dev] [PATCH i-g-t v5 2/2] Add device selection for IGT

Katarzyna Dec
2019-08-28T08:48:25Z

On Wed, Aug 28, 2019 at 09:28:26AM +0100, Kempczynski, Zbigniew wrote:
> On Wed, 2019-08-28 at 08:18 +0200, Katarzyna Dec wrote:
> > On Fri, Aug 23, 2019 at 09:03:51AM +0200, Zbigniew Kempczyński wrote:
> > > New IGT command line argument --device, IGT_DEVICE enviroment
> > > and .igtrc Common::Device were added to allow selecting device
> > > using device selection API.
> > >
> > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Petri Latvala <petri.latvala@intel.com>
> >
> > Code looks good, but I found some hole in usage. When you give wrong value
> > to
> > '--device' parameter while running igt test - binary 'hangs' looping
> > infinitely.
> > Does it supposed to work like that?
> > Kasia :)
>
> Some tests are prone to loop forever when there's some fail (my code
> does nothing to that).
>
> If you try to run gem_busy test for example on your desktop with running
> compositor (which is drm master) you'll fail and get into infinite loop.
>
> Zbigniew
Ok, I guess I picked the wrong binary for test :)

Code looks good and my testing passes:
Reviewed-by: Katarzyna Dec <katarzana.dec@intel.com>
Kasia :)