public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/2] lib/igt_kms: Remove stale restrictions for HSW/BDW HDMI connector forcing
Date: Fri, 23 Aug 2019 21:33:05 +0300	[thread overview]
Message-ID: <20190823183306.24711-1-ville.syrjala@linux.intel.com> (raw)

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We have no problems forcing HDMI connector status on HSW/BDW these days.
Remove the bogus restriction.

Also DP forcing doesn't really work on any platform because the kernel
can't get the DPCD if there's nothing actually connected. So keep
refusing DP forcing, and in fact extend it to all platforms.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_kms.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 17a7d2b67f82..d8cdae76c913 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -980,23 +980,15 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
 	char *path, **tmp;
 	const char *value;
 	drmModeConnector *temp;
-	uint32_t devid;
 	int len, dir, idx;
 
-	if (is_i915_device(drm_fd)) {
-		devid = intel_get_drm_devid(drm_fd);
-
-		/*
-		 * forcing hdmi or dp connectors on HSW and BDW doesn't
-		 * currently work, so fail early to allow the test to skip if
-		 * required
-		 */
-		if ((connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
-		     connector->connector_type == DRM_MODE_CONNECTOR_HDMIB ||
-		     connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
-		    && (IS_HASWELL(devid) || IS_BROADWELL(devid)))
-			return false;
-	}
+	/*
+	 * Forcing DP connectors doesn't currently work, so
+	 * fail early to allow the test to skip if required.
+	 */
+	if (is_i915_device(drm_fd) &&
+	    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
+		return false;
 
 	switch (state) {
 	case FORCE_CONNECTOR_ON:
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-08-23 18:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 18:33 Ville Syrjala [this message]
2019-08-23 18:33 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_force_connector_basic: Execute with HDMI connectors Ville Syrjala
2019-08-26 13:36   ` Ser, Simon
2019-08-23 20:07 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/igt_kms: Remove stale restrictions for HSW/BDW HDMI connector forcing Patchwork
2019-08-24 23:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-08-26 13:05 ` [igt-dev] [PATCH i-g-t 1/2] " Ser, Simon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823183306.24711-1-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox