Re: [igt-dev] [PATCH i-g-t 2/2] tools/intel_vbt_decode: dump all backlight data

Ser, Simon
2019-08-23T13:38:02Z

On Fri, 2019-08-23 at 15:29 +0300, Jani Nikula wrote:
> We were missing the level and control method.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Makes sense

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
> tools/intel_vbt_decode.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 25399d33b8db..deba47994c89 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -229,6 +229,7 @@ static void dump_backlight_info(struct context *context,
> {
> const struct bdb_lfp_backlight_data *backlight = block->data;
> const struct lfp_backlight_data_entry *blc;
> + const struct lfp_backlight_control_method *control;
> int i;
>
> if (sizeof(*blc) != backlight->entry_size) {
> @@ -250,8 +251,14 @@ static void dump_backlight_info(struct context *context,
> printf("\t\tActive low: %u\n", blc->active_low_pwm);
> printf("\t\tPWM freq: %u\n", blc->pwm_freq_hz);
> printf("\t\tMinimum brightness: %u\n", blc->min_brightness);
> - }
>
> + printf("\t\tLevel: %u\n", backlight->level[i]);
> +
> + control = &backlight->backlight_control[i];
> +
> + printf("\t\tControl type: %u\n", control->type);
> + printf("\t\tController: %u\n", control->controller);
> + }
> }
>
> static const struct {