public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors
Date: Mon, 26 Aug 2019 16:02:38 +0300	[thread overview]
Message-ID: <20190826130238.9861-1-simon.ser@intel.com> (raw)

Comments say that a connector can only be forced if it's disconnected. This was
a wrong assumption which has been fixed, but the comments went out of sync.

Fixes: dc3a0934a177 ("tests/kms_hdmi_inject: Accept any HDMI connector")
Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_hdmi_inject.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
index 521105062dad..d9ab4095b8c5 100644
--- a/tests/kms_hdmi_inject.c
+++ b/tests/kms_hdmi_inject.c
@@ -34,9 +34,9 @@
 #define VDISPLAY_4K	2160

 IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
-		     "expected results by forcing a disconnected HDMI "
-		     "connector with a known EDID and checking that the "
-		     "metadata exposed to user space matches.");
+		     "expected results by forcing a HDMI connector "
+		     "with a known EDID and checking that the metadata "
+		     "exposed to user space matches.");

 /**
  * This collection of tests performs EDID and status injection tests. Injection
@@ -49,8 +49,6 @@ IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
  * - 4K modes exposed via KMS
  * - Audio capabilities of the monitor exposed via ALSA. EDID-Like Data (ELD)
  *   entries in /proc/asound are verified.
- *
- * Injection is performed on a disconnected connector.
  */

 /** get_connector: get the first disconnected HDMI connector */
--
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-08-26 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 13:02 Simon Ser [this message]
2019-08-26 13:15 ` [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors Ville Syrjälä
2019-08-26 14:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826130238.9861-1-simon.ser@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox