From: Katarzyna Dec <katarzyna.dec@intel.com>
To: "Kempczynski, Zbigniew" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Petri Latvala <petri.latvala@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [PATCH i-g-t v5 2/2] Add device selection for IGT
Date: Wed, 28 Aug 2019 10:48:22 +0200 [thread overview]
Message-ID: <20190828084822.GP21194@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <db27be2c93320c5e1151ecbec1f6b86b1b8584fa.camel@intel.com>
On Wed, Aug 28, 2019 at 09:28:26AM +0100, Kempczynski, Zbigniew wrote:
> On Wed, 2019-08-28 at 08:18 +0200, Katarzyna Dec wrote:
> > On Fri, Aug 23, 2019 at 09:03:51AM +0200, Zbigniew Kempczyński wrote:
> > > New IGT command line argument --device, IGT_DEVICE enviroment
> > > and .igtrc Common::Device were added to allow selecting device
> > > using device selection API.
> > >
> > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Petri Latvala <petri.latvala@intel.com>
> >
> > Code looks good, but I found some hole in usage. When you give wrong value
> > to
> > '--device' parameter while running igt test - binary 'hangs' looping
> > infinitely.
> > Does it supposed to work like that?
> > Kasia :)
>
> Some tests are prone to loop forever when there's some fail (my code
> does nothing to that).
>
> If you try to run gem_busy test for example on your desktop with running
> compositor (which is drm master) you'll fail and get into infinite loop.
>
> Zbigniew
Ok, I guess I picked the wrong binary for test :)
Code looks good and my testing passes:
Reviewed-by: Katarzyna Dec <katarzana.dec@intel.com>
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-08-28 8:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 7:03 [igt-dev] [PATCH i-g-t v5 0/2] Add device selection methods Zbigniew Kempczyński
2019-08-23 7:03 ` [igt-dev] [PATCH i-g-t v5 1/2] Introduce device selection API Zbigniew Kempczyński
2019-08-28 6:10 ` Katarzyna Dec
2019-08-28 8:23 ` Kempczynski, Zbigniew
2019-08-28 9:00 ` Katarzyna Dec
2019-09-03 6:04 ` Arkadiusz Hiler
2019-08-23 7:03 ` [igt-dev] [PATCH i-g-t v5 2/2] Add device selection for IGT Zbigniew Kempczyński
2019-08-28 6:18 ` Katarzyna Dec
2019-08-28 8:28 ` Kempczynski, Zbigniew
2019-08-28 8:48 ` Katarzyna Dec [this message]
2019-09-03 6:05 ` Arkadiusz Hiler
2019-09-03 6:51 ` Arkadiusz Hiler
2019-09-03 12:23 ` Kempczynski, Zbigniew
2019-08-23 9:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Add device selection methods (rev5) Patchwork
2019-08-24 2:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828084822.GP21194@kdec5-desk.ger.corp.intel.com \
--to=katarzyna.dec@intel.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox