From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t] Dockerfile: Avoid touching external resources
Date: Fri, 30 Aug 2019 11:29:13 +0300 [thread overview]
Message-ID: <20190830082913.20283-1-arkadiusz.hiler@intel.com> (raw)
Let's install all the necessary things in the build-* images, so we
don't touch/hammer external servers each time there is a small change in
IGT.
We have already seen this failing:
Error: Error downloading packages:
Status code: 503 for https://mirrors.fedoraproject.org/metalink?repo=fedora-30&arch=x86_64
The command '/bin/sh -c dnf install -y findutils && dnf clean all' returned a non-zero code: 1
Cc: Oleg Vasilev <oleg.vasilev@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
Dockerfile | 3 ---
Dockerfile.build-fedora | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Dockerfile b/Dockerfile
index b601aecd..7ea266d3 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,9 +1,6 @@
# Version number to bump for force image rebuild: 0
FROM build-fedora
-RUN dnf install -y findutils && \
- dnf clean all
-
COPY opt-igt /opt/igt
COPY .gitlab-ci/docker-help.sh /usr/local/bin/docker-help.sh
diff --git a/Dockerfile.build-fedora b/Dockerfile.build-fedora
index fa27a623..4ccaadd1 100644
--- a/Dockerfile.build-fedora
+++ b/Dockerfile.build-fedora
@@ -37,6 +37,9 @@ RUN rm -fr /tmp/peg
# For compile-testing on clang
RUN dnf install -y clang
+# For the helpers for the container with IGT inside
+RUN dnf install -y findutils
+
# Meson version switching shenanigans
WORKDIR /usr/src
RUN curl -O https://files.pythonhosted.org/packages/c0/9b/44cdb8adcbb186be6cba5c93718d0c68f177b0e8082ae00cafa63a1d3535/meson-0.47.0.tar.gz
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-08-30 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 8:29 Arkadiusz Hiler [this message]
2019-08-30 9:08 ` [igt-dev] ✓ Fi.CI.BAT: success for Dockerfile: Avoid touching external resources Patchwork
2019-08-30 9:21 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-08-31 1:55 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830082913.20283-1-arkadiusz.hiler@intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox