From: Matt Roper <matthew.d.roper@intel.com>
To: "Ser, Simon" <simon.ser@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Skip on platforms without atomic modesetting
Date: Fri, 30 Aug 2019 08:58:07 -0700 [thread overview]
Message-ID: <20190830155807.GX13677@mdroper-desk.amr.corp.intel.com> (raw)
In-Reply-To: <af4dba4e9b212257fd95c5cc4cbfe3358db095cb.camel@intel.com>
On Fri, Aug 30, 2019 at 12:27:45AM -0700, Ser, Simon wrote:
> On Thu, 2019-08-29 at 09:47 -0700, Matt Roper wrote:
> > This test performs display updates via COMMIT_ATOMIC, but fails to check
> > that the platform being tested actually supports atomic. This causes
> > failures on some of our older pre-gen5 platforms.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106012
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
> Reviewed-by: Simon Ser <simon.ser@intel.com>
Pushed, thanks for the review.
Matt
>
> > ---
> > tests/kms_rotation_crc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> > index fe404810..668c1732 100644
> > --- a/tests/kms_rotation_crc.c
> > +++ b/tests/kms_rotation_crc.c
> > @@ -780,6 +780,7 @@ igt_main
> > igt_require_pipe_crc(data.gfx_fd);
> >
> > igt_display_require(&data.display, data.gfx_fd);
> > + igt_require(data.display.is_atomic);
> > }
> >
> > for (subtest = subtests; subtest->rot; subtest++) {
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-08-30 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:47 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Skip on platforms without atomic modesetting Matt Roper
2019-08-29 17:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-08-30 7:27 ` [igt-dev] [PATCH i-g-t] " Ser, Simon
2019-08-30 15:58 ` Matt Roper [this message]
2019-08-30 8:10 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830155807.GX13677@mdroper-desk.amr.corp.intel.com \
--to=matthew.d.roper@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox