public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: fix missing reprobe_connector
Date: Wed,  4 Sep 2019 11:32:45 +0300	[thread overview]
Message-ID: <20190904083245.10273-1-simon.ser@intel.com> (raw)

A reprobe_connector has been mungled by mistake in a previous patch. The old
connector status was used, which always failed because it's asserted to be
DRM_MODE_CONNECTED before the unplug.

Signed-off-by: Simon Ser <simon.ser@intel.com>
Fixes: 87209d8421ea ("tests/kms_chamelium: chatty connector status assertions")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111407
---
 tests/kms_chamelium.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index d6aec8b97eb2..6b6292497cd7 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -271,6 +271,7 @@ test_basic_hotplug(data_t *data, struct chamelium_port *port, int toggle_count)
 		chamelium_unplug(data->chamelium, port);
 		igt_assert_f(igt_hotplug_detected(mon, HOTPLUG_TIMEOUT),
 			     "Timed out waiting for unplug uevent\n");
+		status = reprobe_connector(data, port);
 		igt_assert_f(status == DRM_MODE_DISCONNECTED,
 			     "Invalid connector status after hotplug: "
 			     "got %s, expected disconnected\n",
--
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-09-04  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04  8:32 Simon Ser [this message]
2019-09-04  8:35 ` [igt-dev] [PATCH i-g-t] tests/kms_chamelium: fix missing reprobe_connector Arkadiusz Hiler
2019-09-04  9:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-04 10:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190904083245.10273-1-simon.ser@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox