From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jyoti.r.yadav@intel.com
Subject: [igt-dev] [PATCH i-g-t v14 6/6] tests/i915/i915_pm_dc:Skip the DC6 test if BIOS has disabled PC8+
Date: Fri, 6 Sep 2019 19:35:28 +0530 [thread overview]
Message-ID: <20190906140528.20975-7-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20190906140528.20975-1-anshuman.gupta@intel.com>
As DC6 requires platform to enter PC8 package C state.
It make sense to skip the DC6 igt-test, if BIOS configuration
has disabled PC8+ package C states.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/i915/i915_pm_dc.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index b93466a7..86c12adf 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -23,10 +23,12 @@
*/
#include <errno.h>
+#include <fcntl.h>
#include <stdbool.h>
#include <stdio.h>
#include <string.h>
#include "igt.h"
+#include "igt_kmod.h"
#include "igt_psr.h"
#include "igt_sysfs.h"
#include "limits.h"
@@ -37,6 +39,7 @@
typedef struct {
int drm_fd;
+ int msr_fd;
int debugfs_fd;
uint32_t devid;
igt_display_t display;
@@ -253,6 +256,12 @@ int main(int argc, char *argv[])
igt_require(has_runtime_pm);
igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
igt_display_require(&data.display, data.drm_fd);
+ /* Make sure our Kernel supports MSR and the module is loaded */
+ igt_require(igt_kmod_load("msr", NULL) == 0);
+
+ data.msr_fd = open("/dev/cpu/0/msr", O_RDONLY);
+ igt_assert_f(data.msr_fd >= 0,
+ "Can't open /dev/cpu/0/msr.\n");
}
igt_describe("DC5 igt test with PSR Sleep state");
@@ -270,6 +279,8 @@ int main(int argc, char *argv[])
psr_enable(data.debugfs_fd, data.op_psr_mode);
igt_require_f(edp_psr_sink_support(&data),
"Sink does not support PSR\n");
+ igt_require_f(is_bios_limits_pc8_plus_residencies(data.msr_fd),
+ "PC8+ residencies not supported\n");
test_dc_state_psr(&data, CHECK_DC6);
}
@@ -280,11 +291,14 @@ int main(int argc, char *argv[])
igt_describe("DC6 igt test with all connectors DPMS OFF/ON");
igt_subtest("dc6-dpms") {
+ igt_require_f(is_bios_limits_pc8_plus_residencies(data.msr_fd),
+ "PC8+ residencies not supported\n");
test_dc_state_dpms(&data, CHECK_DC6);
}
igt_fixture {
close(data.debugfs_fd);
+ close(data.msr_fd);
display_fini(&data);
}
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-09-06 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 14:05 [igt-dev] [PATCH i-g-t v14 0/6] DC states igt tests patch series Anshuman Gupta
2019-09-06 14:05 ` [igt-dev] [PATCH i-g-t v14 1/6] lib/igt_pm: igt lib helper routines to support DC5/6 tests Anshuman Gupta
2019-09-17 16:55 ` Imre Deak
2019-09-06 14:05 ` [igt-dev] [PATCH i-g-t v14 3/6] tests/i915/i915_pm_dc: Added test for DC6 during PSR Anshuman Gupta
2019-09-06 14:05 ` [igt-dev] [PATCH i-g-t v14 4/6] tests/i915/i915_pm_dc: Added test for DC5 during DPMS Anshuman Gupta
2019-09-06 14:05 ` [igt-dev] [PATCH i-g-t v14 5/6] tests/i915/i915_pm_dc: Added test for DC6 " Anshuman Gupta
2019-09-06 14:05 ` Anshuman Gupta [this message]
2019-09-06 14:39 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev20) Patchwork
2019-09-06 16:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-09-19 17:30 [igt-dev] [PATCH i-g-t v14 0/6] DC states igt tests patch series Anshuman Gupta
2019-09-19 17:30 ` [igt-dev] [PATCH i-g-t v14 6/6] tests/i915/i915_pm_dc:Skip the DC6 test if BIOS has disabled PC8+ Anshuman Gupta
2019-09-04 17:51 [igt-dev] [PATCH i-g-t v14 0/6] DC states igt tests patch series Anshuman Gupta
2019-09-04 17:51 ` [igt-dev] [PATCH i-g-t v14 6/6] tests/i915/i915_pm_dc:Skip the DC6 test if BIOS has disabled PC8+ Anshuman Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906140528.20975-7-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jyoti.r.yadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox