public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Stanislav.Lisovskiy@intel.com
Subject: [igt-dev] [PATCH i-g-t v1] igt/lib: Don't refresh output in igt_output_set_pipe
Date: Mon,  9 Sep 2019 15:08:16 +0300	[thread overview]
Message-ID: <20190909120816.26074-1-stanislav.lisovskiy@intel.com> (raw)

There are some bugs where DP seems to dissappear in the
middle of test case, which causes garbage modes being returned
for output causing some test cases to fail in unexpected places.
igt_output_refresh should only be called during igt_display_require.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=109495

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 lib/igt_kms.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 17a7d2b6..6d990221 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -3754,8 +3754,6 @@ void igt_output_set_pipe(igt_output_t *output, enum pipe pipe)
 
 	igt_output_set_prop_value(output, IGT_CONNECTOR_CRTC_ID, pipe == PIPE_NONE ? 0 : display->pipes[pipe].crtc_id);
 
-	igt_output_refresh(output);
-
 	if (pipe_obj) {
 		if (display->is_atomic)
 			igt_pipe_obj_replace_prop_blob(pipe_obj, IGT_CRTC_MODE_ID, igt_output_get_mode(output), sizeof(drmModeModeInfo));
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-09-09 12:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 12:08 Stanislav Lisovskiy [this message]
2019-09-09 12:51 ` [igt-dev] ✗ Fi.CI.BAT: failure for igt/lib: Don't refresh output in igt_output_set_pipe Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190909120816.26074-1-stanislav.lisovskiy@intel.com \
    --to=stanislav.lisovskiy@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox