Re: [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding

Kazlauskas, Nicholas
2019-09-16T12:35:52Z

On 2019-09-13 5:57 a.m., Petri Latvala wrote:
> On Wed, Sep 11, 2019 at 02:29:51PM +0000, Kazlauskas, Nicholas wrote:
>> On 2019-09-11 10:11 a.m., Wang, Chao-kai (Stylon) wrote:
>>> From: Stylon Wang <stylon.wang@amd.com>
>>>
>>> HDMI 2.0 compliance tests needs 4K modes with YUV encoding.
>>> This test selects 4K modes based on specified VIC.
>>
>> It helps to note what changed in a patch series in both the patch title
>> and in the commit message here.
>>
>> You can add a v2 to the patch header by appending a -v2 to your command, eg:
>>
>> "git send-email -v2 ..."
>>
>> And in the commit description you should do something like:
>>
>> v2:
>> - example change 1
>> - example change 2
>>
>> Other than that, I do have some general comments and nitpicks:
>>
>> I think this tool might be better off named as just amd_hdmi_compliance
>> so we can expand on this later.
>
> Is there anything specific that makes this tool AMD-specific? It even
> uses DRIVER_ANY.
>
> I guess the same question can be asked about intel_dp_compliance.c...
>
>
>

Nothing yet that I can see in the patch itself.

I know that debugfs entries to help with automating this compliance were
added to amdgpu (like the one that controls 420 vs 444 output), so I
would imagine that they would be added after though.

Nicholas Kazlauskas