From: Petri Latvala <petri.latvala@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] meson: Bump required version to 0.47.2
Date: Fri, 13 Sep 2019 12:52:51 +0300 [thread overview]
Message-ID: <20190913095251.GP4019@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190909134645.21574-1-arkadiusz.hiler@intel.com>
On Mon, Sep 09, 2019 at 04:46:45PM +0300, Arkadiusz Hiler wrote:
> Any distribution that decided to go with 0.47 should also pack the
> latest point release.
>
> For us 0.47.2 is important because it fixes the weird issues with using
> a 'feature' option as a dependency()'s 'required' parameter, e.g.:
>
> option('oping',
> type : 'feature',
> description : 'Build test runner with liboping for pinging support')
>
> liboping = dependency('liboping', required: get_option('oping'))
>
> With liboping not installed and oping option having the default "auto"
> value this should execute just fine and liboping.found() should ==
> false, but instead we get "ERROR: Native dependency 'liboping' not found".
>
> That behavior is fixed with 0.47.2.
>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> Dockerfile.build-fedora | 2 +-
> meson.build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Dockerfile.build-fedora b/Dockerfile.build-fedora
> index f5566b40..ce50376f 100644
> --- a/Dockerfile.build-fedora
> +++ b/Dockerfile.build-fedora
> @@ -41,6 +41,6 @@ RUN dnf install -y clang
> RUN dnf install -y findutils
>
> # Meson version switching shenanigans
> -RUN curl -o "/usr/src/#1" "https://files.pythonhosted.org/packages/c0/9b/44cdb8adcbb186be6cba5c93718d0c68f177b0e8082ae00cafa63a1d3535/{meson-0.47.0.tar.gz}"
> +RUN curl -o "/usr/src/#1" "https://files.pythonhosted.org/packages/e8/ec/3e6a68c9e0fd4b4f4fb6877a3ccfb6f6e6d09f2b4fc87674e671bf64b7b8/{meson-0.47.2.tar.gz}"
>
> RUN dnf clean all
> diff --git a/meson.build b/meson.build
> index aeecf0dc..fd3b6324 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -7,7 +7,7 @@ project('igt-gpu-tools', 'c',
> 'buildtype=debugoptimized',
> ],
> license : 'MIT',
> - meson_version : '>=0.47.0')
> + meson_version : '>=0.47.2')
>
> if get_option('b_ndebug') != 'false'
> error('Building without -Db_ndebug=false is not supported')
> --
> 2.21.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-09-13 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 13:46 [igt-dev] [PATCH i-g-t] meson: Bump required version to 0.47.2 Arkadiusz Hiler
2019-09-09 15:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-09 22:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-09-13 9:52 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913095251.GP4019@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox