Re: [igt-dev] [PATCH i-g-t 1/3] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL

Ashutosh Dixit
2019-09-18T05:06:50Z

On Tue, 17 Sep 2019 21:56:49 -0700, Katarzyna Dec wrote:
>
> On Tue, Sep 17, 2019 at 09:51:50PM -0700, Ashutosh Dixit wrote:
> > I ran the kernel checkpatch on the patch and found a couple of minor
> > issues. Perhaps it is a good idea to run checkpatch even on non-kernel
> > patches in the future and fix up whatever can be fixed up.
>
> I am using checkpatch on daily basis and I didn't found any issues. I run it
> again and only '--strct' option shows hints (not warnings). I can change that,
> but in my opinion it is not needed.
> Let me know what you think.

Well checkpatch --strict has found small issues which I have mentioned in
the two patches under the affected lines. IMO they should be fixed
up. Thanks!
--
Ashutosh