From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADDF56F96E for ; Fri, 20 Sep 2019 10:25:02 +0000 (UTC) Date: Fri, 20 Sep 2019 13:25:00 +0300 From: Petri Latvala Message-ID: <20190920102500.GZ4019@platvala-desk.ger.corp.intel.com> References: <20190920010723.27300-1-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190920010723.27300-1-lucas.demarchi@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] lib/kmod: reimplement kmsg_dump() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lucas De Marchi Cc: igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCBTZXAgMTksIDIwMTkgYXQgMDY6MDc6MjNQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IC9kZXYva21zZyBpcyByZWNvcmQtb3JpZW50ZWQgcmF0aGVyIHRoYW4gbGluZS1v cmllbnRlZC4gQSBzaG9ydCByZWFkIGluCj4gd2hpY2ggdGhlIHJlY29yZCBkb2Vzbid0IGZpdCB3 aWxsIHJldHVybiAtRUlOVkFMIGFuZCBnZXRsaW5lKCkgd2lsbCBzdG9wCj4gd29ya2luZy4gVGhp cyBpcyBpbiBnZW5lcmFsIG5vdCBhIHByb2JsZW0gc2luY2UgdGhlIChkZWZhdWx0KSBzdGRpbwo+ IGJ1ZmZlciBpcyBiaWdnZXIgdGhhbiB0aGUgbWF4aW11bSByZWNvcmQgc2l6ZSAoNDA5NikuIEhv d2V2ZXIgbGV0J3MKPiBhYmlkZSBieSB0aGUga2VybmVsIEFCSSByYXRoZXIgdGhhbiByZWx5aW5n IG9uIHRoZSBsaWJjIGJ1ZmZlciBzaXplLgo+IAo+IFdoaWxlIHJlaW1wbGVtZW50aW5nLCBmaXgg dGhlIGZvbGxvd2luZyBpc3N1ZXMgdGhhdCBtYWRlIG1lIGxvb2sgdG8gdGhlCj4gaW1wbGVtZW50 YXRpb24gaW4gdGhlIGZpcnN0IHBsYWNlOgo+IAo+IDEpIHdlIHdlcmUgc2tpcHBpbmcgMSBjaGFy IGluIHRoZSBtZXNzYWdlLCBwcm9kdWNpbmcgbWVzc2FnZXMgbGlrZSB0aGUKPiAgICBvbmUgYmVs b3cgKHNlZSB0aGUgbWlzc2luZyBpIGluIGludGVsX3BjaF90eXBlKToKPiAJKGk5MTVfc2VsZnRl c3Q6Mzg2MSkgaWd0X2ttb2QtV0FSTklORzogbnRlbF9wY2hfdHlwZSBbaTkxNV1dIEZvdW5kIFRp Z2VyIExha2UgTFAgUENICj4gCj4gMikgd2Ugd2VyZSBwcmludGluZyB0aGUga2V5PXZhbCBwYWly IG9mIGttc2cgYXMgaWYgaXQgd2FzIHBhcnQgb2YgdGhlCj4gbWVzc3NhZ2VzLCBhbmQgZXZlbiBt YW5nbGluZyB0aGUgcmVzdWx0IGxvb2tpbmcgZm9yIGEgJzonOgo+IAkoaTkxNV9zZWxmdGVzdDoz ODYxKSBpZ3Rfa21vZC1XQVJOSU5HOiAwMDA6MDA6MDIuMAo+IAo+IFRoZSBBQkkgZm9yIC9kZXYv a21zZyBzdGFuZHM6Cj4gCUFjY2Vzc2luZyB0aGUgYnVmZmVyOgo+IAkJRXZlcnkgcmVhZCgpIGZy b20gdGhlIG9wZW5lZCBkZXZpY2Ugbm9kZSByZWNlaXZlcyBvbmUgcmVjb3JkCj4gCQlvZiB0aGUg a2VybmVsJ3MgcHJpbnRrIGJ1ZmZlci4KPiAKPiAJCVsgLi4uIF0KPiAKPiAJCUZ1dHVyZSBleHRl bnNpb25zIG1pZ2h0IGFkZCBtb3JlIGNvbW1hIHNlcGFyYXRlZCB2YWx1ZXMgYmVmb3JlCj4gCQl0 aGUgdGVybWluYXRpbmcgJzsnLiBVbmtub3duIGZpZWxkcyBhbmQgdmFsdWVzIHNob3VsZCBiZQo+ IAkJZ3JhY2VmdWxseSBpZ25vcmVkLgo+IAo+IAkJVGhlIGh1bWFuIHJlYWRhYmxlIHRleHQgc3Ry aW5nIHN0YXJ0cyBkaXJlY3RseSBhZnRlciB0aGUgJzsnCj4gCQlhbmQgaXMgdGVybWluYXRlZCBi eSBhICdcbicuIFVudHJ1c3RlZCB2YWx1ZXMgZGVyaXZlZCBmcm9tCj4gCQloYXJkd2FyZSBvciBv dGhlciBmYWNpbGl0aWVzIGFyZSBwcmludGVkLCB0aGVyZWZvcmUKPiAJCWFsbCBub24tcHJpbnRh YmxlIGNoYXJhY3RlcnMgYW5kICdcJyBpdHNlbGYgaW4gdGhlIGxvZyBtZXNzYWdlCj4gCQlhcmUg ZXNjYXBlZCBieSAiXHgwMCIgQy1zdHlsZSBoZXggZW5jb2RpbmcuCj4gCj4gCQlBIGxpbmUgc3Rh cnRpbmcgd2l0aCAnICcsIGlzIGEgY29udGludWF0aW9uIGxpbmUsIGFkZGluZwo+IAkJa2V5L3Zh bHVlIHBhaXJzIHRvIHRoZSBsb2cgbWVzc2FnZSwgd2hpY2ggcHJvdmlkZSB0aGUgbWFjaGluZQo+ IAkJcmVhZGFibGUgY29udGV4dCBvZiB0aGUgbWVzc2FnZSwgZm9yIHJlbGlhYmxlIHByb2Nlc3Np bmcgaW4KPiAJCXVzZXJzcGFjZS4KPiAKPiBOb3cgdGhlIGxpbmUgaW4gKDEpIHByaW50IGFzOgo+ IAkoaTkxNV9zZWxmdGVzdDo1MDcwKSBpZ3Rfa21vZC1XQVJOSU5HOiBbZHJtOmludGVsX3BjaF90 eXBlIFtpOTE1XV0gRm91bmQgVGlnZXIgTGFrZSBMUCBQQ0gKPiAKPiBUaGlzIGFsc28gZml4ZXMg YSBkb3VibGUgY2xvc2Ugb24gZmNsb3NlKCkgYWxyZWFkeSBjbG9zZXMgdGhlIGZpbGUKPiBkZXNj cmlwdG9yLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJj aGlAaW50ZWwuY29tPgo+IC0tLQo+ICBsaWIvaWd0X2ttb2QuYyB8IDQzICsrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2Vy dGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ttb2Qu YyBiL2xpYi9pZ3Rfa21vZC5jCj4gaW5kZXggOTE2NjJlYjMuLjAxZmFjYTM5IDEwMDY0NAo+IC0t LSBhL2xpYi9pZ3Rfa21vZC5jCj4gKysrIGIvbGliL2lndF9rbW9kLmMKPiBAQCAtMzc0LDI1ICsz NzQsMzQgQEAgaWd0X2k5MTVfZHJpdmVyX3VubG9hZCh2b2lkKQo+ICAKPiAgc3RhdGljIHZvaWQg a21zZ19kdW1wKGludCBmZCkKPiAgewo+IC0JRklMRSAqZmlsZTsKPiAtCj4gLQlmaWxlID0gTlVM TDsKPiAtCWlmIChmZCAhPSAtMSkKPiAtCQlmaWxlID0gZmRvcGVuKGZkLCAiciIpOwo+IC0JaWYg KGZpbGUpIHsKPiAtCQlzaXplX3QgbGVuID0gMDsKPiAtCQljaGFyICpsaW5lID0gTlVMTDsKPiAt Cj4gLQkJd2hpbGUgKGdldGxpbmUoJmxpbmUsICZsZW4sIGZpbGUpICE9IC0xKSB7Cj4gLQkJCWNo YXIgKnN0YXJ0ID0gc3RyY2hyKGxpbmUsICc6Jyk7Cj4gLQkJCWlmIChzdGFydCkKPiAtCQkJCWln dF93YXJuKCIlcyIsIHN0YXJ0ICsgMik7Cj4gLQkJfQo+ICsJY2hhciByZWNvcmRbNDA5NiArIDFd Owo+ICAKPiAtCQlmcmVlKGxpbmUpOwo+IC0JCWZjbG9zZShmaWxlKTsKPiAtCX0gZWxzZSB7Cj4g KwlpZiAoZmQgPT0gLTEpIHsKPiAgCQlpZ3Rfd2FybigiVW5hYmxlIHRvIHJldHJpZXZlIGtlcm5l bCBsb2cgKGZyb20gL2Rldi9rbXNnKVxuIik7Cj4gKwkJcmV0dXJuOwo+ICsJfQo+ICsKPiArCXJl Y29yZFtzaXplb2YocmVjb3JkKSAtIDFdID0gJ1wwJzsKPiArCj4gKwlmb3IgKDs7KSB7Cj4gKwkJ Y29uc3QgY2hhciAqc3RhcnQsICplbmQ7Cj4gKwkJc3NpemVfdCByOwo+ICsKPiArCQlyID0gcmVh ZChmZCwgcmVjb3JkLCBzaXplb2YocmVjb3JkKSAtIDEpOwo+ICsJCWlmIChyIDwgMCkgewo+ICsJ CQlpZiAoZXJybm8gPT0gRUlOVFIpCj4gKwkJCQljb250aW51ZTsKPiArCQkJaWYgKGVycm5vICE9 IEVBR0FJTikKPiArCQkJCWlndF93YXJuKCJrbXNnIHRydW5jYXRlZCBkdWUgdG8gdW5rbm93biBl cnJvcjogJW1cbiIpOwo+ICsJCQlicmVhazsKPiArCQl9Cj4gKwo+ICsJCXN0YXJ0ID0gc3RyY2hy KHJlY29yZCwgJzsnKTsKPiArCQlpZiAoc3RhcnQpIHsKPiArCQkJc3RhcnQrKzsKPiArCQkJZW5k ID0gc3RyY2hybnVsKHN0YXJ0LCAnXG4nKTsKPiArCQkJaWd0X3dhcm4oIiUuKnNcbiIsIChpbnQp KGVuZCAtIHN0YXJ0KSwgc3RhcnQpOwo+ICsJCX0KPiAgCX0KPiAgfQoKClJldmlld2VkLWJ5OiBQ ZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGludGVsLmNvbT4KCgpDYW4gSSBpbnRlcmVzdCB5 b3UgaW4gcmVmYWN0b3JpbmcgdGhpcyBhbmQgcGFyc2VfZG1lc2dfbGluZSgpIGluCnJ1bm5lci9y ZXN1bHRnZW4uYyB0b2dldGhlcj8gOlAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p Z3QtZGV2