From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_render_copy: Add hang detector
Date: Mon, 23 Sep 2019 17:48:31 +0300 [thread overview]
Message-ID: <20190923144831.GL1208@intel.com> (raw)
In-Reply-To: <20190923092432.14793-1-chris@chris-wilson.co.uk>
On Mon, Sep 23, 2019 at 10:24:32AM +0100, Chris Wilson wrote:
> Die early if the GPU hangs during our basic render copy testing, and
> clean up rather than waiting for multiple different failing batches
> before detecting our failure.
Seems sensible.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_render_copy.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/i915/gem_render_copy.c b/tests/i915/gem_render_copy.c
> index b8149483c..261833d24 100644
> --- a/tests/i915/gem_render_copy.c
> +++ b/tests/i915/gem_render_copy.c
> @@ -715,6 +715,8 @@ igt_main_args("da", NULL, help_str, opt_handler, NULL)
>
> data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
> igt_assert(data.batch);
> +
> + igt_fork_hang_detector(data.drm_fd);
> }
>
> igt_subtest("linear")
> @@ -745,6 +747,7 @@ igt_main_args("da", NULL, help_str, opt_handler, NULL)
> test(&data, I915_TILING_Yf, I915_TILING_Yf);
>
> igt_fixture {
> + igt_stop_hang_detector();
> intel_batchbuffer_free(data.batch);
> drm_intel_bufmgr_destroy(data.bufmgr);
> }
> --
> 2.23.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-09-23 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 9:24 [igt-dev] [PATCH i-g-t] i915/gem_render_copy: Add hang detector Chris Wilson
2019-09-23 10:07 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-23 14:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-09-23 14:48 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923144831.GL1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox