public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_eio: Include non-context based tests for older kms testing
Date: Tue, 24 Sep 2019 11:49:20 +0300	[thread overview]
Message-ID: <20190924084920.GE2884@intel.intel> (raw)
In-Reply-To: <20190923074149.19753-1-chris@chris-wilson.co.uk>

Hi Chris,

On Mon, Sep 23, 2019 at 08:41:49AM +0100, Chris Wilson wrote:
> As not every machine can use contexts, include a non-context reset stress
> test to run in parallel to enabling/disabling pipes.

makes sense.

> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/i915/gem_eio.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index e7f5d4ddb..52e83a5cf 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -870,8 +870,11 @@ static void test_kms(int i915, igt_display_t *dpy)
>  	igt_fork(child, 1)
>  		display_helper(dpy, shared);
>  
> -	test_reset_stress(i915, 0);
> -	test_reset_stress(i915, TEST_WEDGE);
> +	test_inflight(i915, 0);
> +	if (gem_has_contexts(fd)) {

considering that in v2 I am sure you are going to provide an fd
of "some sort" :)

Reveiwed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi

> +		test_reset_stress(i915, 0);
> +		test_reset_stress(i915, TEST_WEDGE);
> +	}
>  
>  	*shared = 1;
>  	igt_waitchildren();
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2019-09-24  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23  7:41 [igt-dev] [PATCH i-g-t] i915/gem_eio: Include non-context based tests for older kms testing Chris Wilson
2019-09-23  9:25 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2019-09-24  8:49 ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190924084920.GE2884@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox