From: Ramalingam C <ramalingam.c@intel.com>
To: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [PATCH] test/kms_content_protection: Use generic debugfs name for HDCP caps
Date: Tue, 24 Sep 2019 21:11:05 +0530 [thread overview]
Message-ID: <20190924154105.GC24421@intel.com> (raw)
In-Reply-To: <20190924095454.GE4019@platvala-desk.ger.corp.intel.com>
On 2019-09-24 at 12:54:54 +0300, Petri Latvala wrote:
> On Mon, Sep 23, 2019 at 02:23:25PM -0400, Bhawanpreet Lakha wrote:
> > Rename "i915_hdcp_sink_capability" to "hdcp_sink_capability"
> >
> > The content protection tests only start if this debugfs entry exists.
> > Since the name is specific to intel driver these tests cannot be used with
> > other drivers.
> >
> > Remove "i915" so the debugfs name is generic.
>
> I don't see any drivers currently using the name
> "hdcp_sink_capability". Is the content of the file in other drivers
> the same as i915's?
>
> And is there a plan to rename i915's debugfs filename to
> hdcp_sink_capability? Ram?
>
> Agreed, for a DRIVER_ANY-using test generic names are preferrable, but
> this needs some kind of a transition plan. If i915's filename is
> staying as is, both names need to be tried.
This IGT test change has to wait untill we have the
i915_hdcp_sink_capabilities renamed, if at all we rename.
Else based on drm_device we could decide the debugfs file and read it.
Daniel,
Considering all other debugfs are prefixed with i915, could we rename this
debugfs as "hdcp_sink_capabilities" instead?
-Ram
>
>
> --
> Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-09-24 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 18:23 [Intel-gfx] [PATCH] test/kms_content_protection: Use generic debugfs name for HDCP caps Bhawanpreet Lakha
2019-09-23 19:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-24 6:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-09-24 9:54 ` [igt-dev] [PATCH] " Petri Latvala
2019-09-24 14:41 ` Lakha, Bhawanpreet
2019-09-24 15:41 ` Ramalingam C [this message]
2019-10-21 21:28 ` [igt-dev] ✓ Fi.CI.BAT: success for test/kms_content_protection: Use generic debugfs name for HDCP caps (rev2) Patchwork
2019-10-22 5:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
[not found] ` <20191021194259.17052-1-Bhawanpreet.Lakha@amd.com>
2019-10-23 14:18 ` [igt-dev] [PATCH i-g-t v2] tests/kms_content_protection: check i915 and generic debugfs name for HDCP caps Harry Wentland
2019-10-23 15:27 ` [igt-dev] [Intel-gfx] " Ramalingam C
2019-10-24 11:17 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924154105.GC24421@intel.com \
--to=ramalingam.c@intel.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).