Re: [igt-dev] [PATCH RFC i-g-t 08/10] lib/igt_fb.c: Update tile sizes for GEN12 Color Clear

Kahola, Mika
2019-10-30T10:32:29Z

On Tue, 2019-10-29 at 14:31 -0700, Radhakrishna Sripada wrote:
> On Wed, Sep 25, 2019 at 04:09:29PM +0300, Mika Kahola wrote:
> > Update tile sizes for GEN12 Color Clear.
> >
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > lib/igt_fb.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index 618e7a63..603636be 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -383,6 +383,7 @@ void igt_get_fb_tile_size(int fd, uint64_t
> > modifier, int fb_bpp,
> > break;
> > case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
> > case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
> > + case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
> > igt_require_intel(fd);
> > switch (fb_bpp) {
> > case 8:
> > @@ -466,6 +467,7 @@ static bool is_ccs_modifier(uint64_t modifier)
> >
> > return modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS ||
> > modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ||
> > + modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ||
>
> I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC uses 3 planes. The third
> plane for Clear Color structure.
> We need to make additional changes to support 3rd plane.
You're right. The kernel counterpart has changed a bit since I wrote
this. I'll update this patch to be aligned with kernel changes.

>
> - Radhakrishna(RK) Sripada
> > modifier == I915_FORMAT_MOD_Y_TILED_CCS ||
> > modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
> > }
> > @@ -688,6 +690,7 @@ uint64_t igt_fb_mod_to_tiling(uint64_t
> > modifier)
> > case LOCAL_I915_FORMAT_MOD_Y_TILED_CCS:
> > case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
> > case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
> > + case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
> > return I915_TILING_Y;
> > case LOCAL_I915_FORMAT_MOD_Yf_TILED:
> > case LOCAL_I915_FORMAT_MOD_Yf_TILED_CCS:
> > --
> > 2.17.1
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev