public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Include breadcrumbs in the kernel log before i915.ko reloads
Date: Thu, 26 Sep 2019 16:17:49 +0300	[thread overview]
Message-ID: <20190926131749.GA3643@intel.intel> (raw)
In-Reply-To: <20190926131006.8506-1-chris@chris-wilson.co.uk>

Hi Chris,

On Thu, Sep 26, 2019 at 02:10:06PM +0100, Chris Wilson wrote:
> Make it easier to discern in the noise of the module reload where each
> begins.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti@intel.com>

thanks for this patch!

Acked-by: Andi Shyti <andi.shyti@intel.com>

Andi

> ---
>  tests/i915/i915_pm_rpm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index a2bdabee2..f5f813c3d 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -2113,6 +2113,8 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>  	igt_subtest("module-reload") {
>  		igt_debug("Reload w/o display\n");
>  		igt_i915_driver_unload();
> +
> +		igt_kmsg(KMSG_INFO "Reloading i915 w/o display\n");
>  		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=-1"), 0);
>  
>  		igt_assert(setup_environment());
> @@ -2121,6 +2123,8 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>  
>  		igt_debug("Reload as normal\n");
>  		igt_i915_driver_unload();
> +
> +		igt_kmsg(KMSG_INFO "Reloading i915 as normal\n");
>  		igt_assert_eq(igt_i915_driver_load("mmio_debug=-1"), 0);
>  
>  		igt_assert(setup_environment());
> -- 
> 2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-09-26 13:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 13:10 [igt-dev] [PATCH i-g-t] i915/pm_rpm: Include breadcrumbs in the kernel log before i915.ko reloads Chris Wilson
2019-09-26 13:17 ` Andi Shyti [this message]
2019-09-26 13:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-27  8:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926131749.GA3643@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox