Re: [igt-dev] [PATCH i-g-t] runner/resultgen: Handle empty outputs

[Arkadiusz Hiler <arkadiusz.hiler@intel.com>]

On Fri, Oct 11, 2019 at 02:52:55PM +0300, Petri Latvala wrote:
> If an output (out.txt or err.txt) is completely empty, we handle the
> parsing just fine as is, but we end up assuming that if journal says
> we have a subtest, that subtest printed that it started. We have one
> case where out.txt was empty and all other files were intact (ran out
> of disk?)

It doesn't look like there was a space issue. CI would mark the node as
offline way before that - we won't start executing anything if there's
not at least 1GB of space free. The offending machine (shard-snb2) has
around 80GB free as of now.

I'll couldn't get apport to work, so I have switched over
systemd-coredump on the reporting machine and I'll keep an eye for any
runner coredumps.

This may account for some of the missing "notrun"s :-)

> All other paths that expect certain texts handle failures finding them
> properly apart from subtest result processing, which happily passed
> along a NULL pointer as a string to json. After handling that case,
> the processing of said weird case proceeded fine and produced correct
> results.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev