From: Petri Latvala <petri.latvala@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] README: Mention Dockerfiles with dependencies by name
Date: Tue, 15 Oct 2019 14:16:20 +0300 [thread overview]
Message-ID: <20191015111620.GO4019@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20191015111301.9581-1-arkadiusz.hiler@intel.com>
On Tue, Oct 15, 2019 at 02:13:01PM +0300, Arkadiusz Hiler wrote:
> Debian has two Dockerfiles associated - minimal and regular one that
> bases on the minimal one.
>
> Let's mention them by name and add a comment providing some context to
> the split so it's easier to figure out what to install on a new system.
>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> Dockerfile.build-debian | 5 +++++
> README.md | 4 ++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Dockerfile.build-debian b/Dockerfile.build-debian
> index 69f63157..36c51765 100644
> --- a/Dockerfile.build-debian
> +++ b/Dockerfile.build-debian
> @@ -2,6 +2,11 @@ ARG CI_COMMIT_SHA
> ARG CI_REGISTRY_IMAGE
> FROM $CI_REGISTRY_IMAGE/build-debian-minimal:commit-$CI_COMMIT_SHA
>
> +# inherits from Dockerfile.build-debian-minimal
> +#
> +# just few extra dependencies for building IGT with all the optional components
> +# enabled
> +
> RUN apt-get update
> RUN apt-get install -y \
> libunwind-dev \
> diff --git a/README.md b/README.md
> index a6a821c0..f33e9455 100644
> --- a/README.md
> +++ b/README.md
> @@ -20,8 +20,8 @@ Generated documentation for the latest master is published under
> Requirements
> ------------
>
> -See `Dockerfile.*` for up-to-date list of package names in Fedora and
> -Debian.
> +See `Dockerfile.build-fedora` for up-to-date list of package names in Fedora
> +or `Dockerfile.build-debian-minimal` and `Dockerfile.build-debian` for Debian.
>
> If your distribution packages IGT you can also use your package manager to
> install the dependencies, e.g.:
> --
> 2.21.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-10-15 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 11:13 [igt-dev] [PATCH i-g-t] README: Mention Dockerfiles with dependencies by name Arkadiusz Hiler
2019-10-15 11:16 ` Petri Latvala [this message]
2019-10-15 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-10-15 21:01 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015111620.GO4019@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox