From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: lucas.demarchi@intel.com, martin.peres@intel.com,
maarten.lankhorst@intel.com
Subject: [igt-dev] [PATCH 7/7] lib: remove igt_skip_on_simulation
Date: Wed, 16 Oct 2019 13:19:12 +0530 [thread overview]
Message-ID: <20191016074912.32290-8-swati2.sharma@intel.com> (raw)
In-Reply-To: <20191016074912.32290-1-swati2.sharma@intel.com>
Removing igt_skip_on_simulation() from lib since this feature
is not supported anymore. Func() defination hasn't been removed
since it can be used by some other drivers (currently amd is using
this function).
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Karthik B S <karthik.b.s@intel.com>
---
lib/igt_aux.c | 7 -------
lib/intel_os.c | 2 --
2 files changed, 9 deletions(-)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 578f8579..55632fd0 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -854,11 +854,6 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
int power_dir;
enum igt_suspend_test orig_test;
- /* FIXME: Simulation doesn't like suspend/resume, and not even a lighter
- * approach using /sys/power/pm_test to just test our driver's callbacks
- * seems to fare better. We need to investigate what's going on. */
- igt_skip_on_simulation();
-
igt_require((power_dir = open("/sys/power", O_RDONLY)) >= 0);
igt_require(get_supported_suspend_states(power_dir) & (1 << state));
igt_require(test == SUSPEND_TEST_NONE ||
@@ -905,8 +900,6 @@ void igt_set_autoresume_delay(int delay_secs)
int delay_fd;
char delay_str[10];
- igt_skip_on_simulation();
-
delay_fd = open("/sys/module/suspend/parameters/pm_test_delay", O_RDWR);
if (delay_fd >= 0) {
diff --git a/lib/intel_os.c b/lib/intel_os.c
index 505831c0..8458d39a 100644
--- a/lib/intel_os.c
+++ b/lib/intel_os.c
@@ -365,8 +365,6 @@ void intel_require_memory(uint64_t count, uint64_t size, unsigned mode)
uint64_t required, total;
bool sufficient_memory;
- igt_skip_on_simulation();
-
sufficient_memory = __intel_check_memory(count, size, mode,
&required, &total);
if (!sufficient_memory) {
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-10-16 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 7:49 [igt-dev] [PATCH 0/7] removal of igt_skip_on_simulation() from i915/ tests Swati Sharma
2019-10-16 7:49 ` [igt-dev] [PATCH 1/7] tests/i915/gem: remove igt_skip_on_simulation() Swati Sharma
2019-10-16 7:49 ` [igt-dev] [PATCH 2/7] tests/i915/kms: " Swati Sharma
2019-10-16 7:49 ` [igt-dev] [PATCH 3/7] tests/i915: " Swati Sharma
2019-10-16 7:49 ` [igt-dev] [PATCH 4/7] tests: " Swati Sharma
2019-10-16 7:49 ` [igt-dev] [PATCH 5/7] tools: " Swati Sharma
2019-10-16 7:49 ` [igt-dev] [PATCH 6/7] benchmarks: " Swati Sharma
2019-10-16 7:49 ` Swati Sharma [this message]
2019-10-16 8:49 ` [igt-dev] [PATCH 0/7] removal of igt_skip_on_simulation() from i915/ tests Martin Peres
2019-10-16 9:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-16 10:53 ` Petri Latvala
2019-10-16 11:11 ` Arkadiusz Hiler
2019-10-16 11:25 ` [igt-dev] ✗ GitLab.Pipeline: warning for removal of igt_skip_on_simulation() from i915/ tests (rev2) Patchwork
2019-10-16 11:31 ` Arkadiusz Hiler
2019-10-16 11:44 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-10-16 21:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-11-18 14:46 ` [igt-dev] [PATCH 0/7] removal of igt_skip_on_simulation() from i915/ tests Katarzyna Dec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016074912.32290-8-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@intel.com \
--cc=martin.peres@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox