From: Manasi Navare <manasi.d.navare@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org,
Madhumitha Tolakanahalli Pradeep
<madhumitha.tolakanahalli.pradeep@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_tiled_display: Get rid of DP stuff
Date: Wed, 16 Oct 2019 12:32:04 -0700 [thread overview]
Message-ID: <20191016193204.GA28637@intel.com> (raw)
In-Reply-To: <20191015122713.GB1208@intel.com>
On Tue, Oct 15, 2019 at 03:27:13PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 14, 2019 at 01:58:58PM -0700, Manasi Navare wrote:
> > On Mon, Oct 14, 2019 at 11:21:22PM +0300, Ville Syrjälä wrote:
> > > On Mon, Oct 14, 2019 at 12:57:33PM -0700, Manasi Navare wrote:
> > > > On Mon, Oct 14, 2019 at 09:13:15PM +0300, Ville Syrjala wrote:
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > >
> > > > > There is nothing DP specific about the tile property. So
> > > > > remove any mention of DP (and port sync which is an i915
> > > > > hardware feature). Let's just talk about genlocked CRTCs
> > > > > and tiled connectors, which is pretty generic.
> > > >
> > > > But we currently dont support the trans port sync feature for other
> > > > connectorrs other than DP so the test will fail so IMO,
> > > > currently it should only run for DP tiled connectors
> > >
> > > That's an i915 specific limitation and if you want to check for that
> > > then the check should be written as 'if (is_i915 && whatever)'.
> > >
> > > >
> > > > even DP MST trans port sync might fail havent added this to MST yet
> > >
> > > Right, so the check isn't correct even on i915 -> better to just nuke it.
> > >
> >
> > So would you modify this patch to add those checks or would that be a follow up patch?
>
> I still don't see the point of adding any checks. The test will just
> fail if the crtcs aren't genlocked, which is totally fine.
Okay sure that makes sense then, it will help catching the issues where
there are corruption issues if crtcs not genlocked
With that then:
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
manasi
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-10-16 19:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:13 [igt-dev] [PATCH i-g-t 1/3] tests/kms_dp_tiled_display: Fix bogus abs() Ville Syrjala
2019-10-14 18:13 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_dp_tiled_display: Flatten the page flip handler Ville Syrjala
2019-10-14 19:55 ` Manasi Navare
2019-10-14 18:13 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_tiled_display: Get rid of DP stuff Ville Syrjala
2019-10-14 19:57 ` Manasi Navare
2019-10-14 20:21 ` Ville Syrjälä
2019-10-14 20:58 ` Manasi Navare
2019-10-15 12:27 ` Ville Syrjälä
2019-10-16 19:32 ` Manasi Navare [this message]
2019-10-14 19:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tests/kms_dp_tiled_display: Fix bogus abs() Patchwork
2019-10-14 19:50 ` [igt-dev] [PATCH i-g-t 1/3] " Manasi Navare
2019-10-15 5:06 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016193204.GA28637@intel.com \
--to=manasi.d.navare@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=madhumitha.tolakanahalli.pradeep@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox