Re: [igt-dev] [PATCH i-g-t 1/4] runner: Produce skip instead of notrun for nonexisting tests

Martin Peres
2019-10-16T11:31:45Z

On 16/10/2019 14:13, Petri Latvala wrote:
> If a test was attempted but didn't actually exist, make it result in a
> skip instead of a notrun. This is to differentiate them from the tests
> that we didn't even attempt, like tests after getting a machine
> hang. This will improve handling of subtests for GEM engines that
> don't exist.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>

Acked-by: Martin Peres <martin.peres@linux.intel.com>

> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> ---
> runner/resultgen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index 46c9d8d5..5faa8555 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -732,7 +732,7 @@ static const char *result_from_exitcode(int exitcode)
> case IGT_EXIT_SUCCESS:
> return "pass";
> case IGT_EXIT_INVALID:
> - return "notrun";
> + return "skip";
> case INCOMPLETE_EXITCODE:
> return "incomplete";
> default:
>