Re: [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable

Souza, Jose
2019-10-24T23:15:08Z

On Thu, 2019-10-24 at 08:00 -0700, Matt Roper wrote:
> On Wed, Oct 23, 2019 at 02:50:30PM -0700, José Roberto de Souza
> wrote:
> > Right now if sink reported any PSR error or if it fails to
> > acknowledge the PSR wakeup it sets a flag and do not attempt to
> > enable PSR anymore. That is the safest approach to avoid repetitive
> > glitches and allowed us to have PSR enabled by default.
> >
> > But from time to time even good PSR panels have a PSR error,
> > causing
> > tests to fail. And for now we are not yet to the point were we
> > could
> > try to recover from PSR errors, so lets check for this information
> > in
> > debugfs and skip PSR tests because of sink errors and eliminate
> > this
> > noise from CI runs.
> >
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Ap Kamal <kamal.ap@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109454
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

Added and pushed

Thanks

>
> and r-b for the i915 patch as well.
>
>
> > ---
> > lib/igt_psr.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> > index b92ea73f..0e79dcd9 100644
> > --- a/lib/igt_psr.c
> > +++ b/lib/igt_psr.c
> > @@ -33,6 +33,8 @@ static bool psr_active_check(int debugfs_fd, enum
> > psr_mode mode)
> > igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
> > sizeof(buf));
> >
> > + igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
> > +
> > return strstr(buf, state);
> > }
> >
> > --
> > 2.23.0
> >