Re: [igt-dev] [PATCH i-g-t 4/8] runner: Parse dynamic subtest outputs and results

Arkadiusz Hiler
2019-10-25T11:03:30Z

On Thu, Oct 24, 2019 at 02:05:42PM +0300, Petri Latvala wrote:
> If binary 'bin' has a subtest 'sub', which has dynamic subtests 'foo'
> and 'bar', results.json will now have "subtests" by the names
> igt@bin@sub@foo and igt@bin@sub@bar, with data as expected of normal
> subtests.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>

Those fill_from_ functions are monstrous... Each time I review changes
there I have to read through the full code on the side first to get
what's going on, and it's still easy to get lost.

Next time we are touching this area it should undergo a modernization...

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>