From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert
Date: Fri, 25 Oct 2019 17:30:50 +0300 [thread overview]
Message-ID: <20191025143050.18205-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20191025143050.18205-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Decode the fourccs to make things a bit more human readable
if the assertion trips.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index aaeca7955418..4adca9672f33 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -3096,8 +3096,10 @@ static void fb_convert(struct fb_convert *cvt)
}
igt_assert_f(false,
- "Conversion not implemented (from format 0x%x to 0x%x)\n",
- cvt->src.fb->drm_format, cvt->dst.fb->drm_format);
+ "Conversion not implemented (from format "
+ IGT_FORMAT_FMT " to " IGT_FORMAT_FMT ")\n",
+ IGT_FORMAT_ARGS(cvt->src.fb->drm_format),
+ IGT_FORMAT_ARGS(cvt->dst.fb->drm_format));
}
static void destroy_cairo_surface__convert(void *arg)
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-10-25 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: Declare format conversions explicitly Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: Don't skip the entire subtest when cairo/pixman is too old Ville Syrjala
2019-10-25 14:30 ` Ville Syrjala [this message]
2019-10-25 15:27 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert Chris Wilson
2019-10-25 15:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Patchwork
2019-10-25 18:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2) Patchwork
2019-10-27 9:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025143050.18205-4-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox