From: Matt Roper <matthew.d.roper@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/i915_pm_lpsp: Don't always fail pfit subtest on 13x7 panels
Date: Fri, 25 Oct 2019 16:50:31 -0700 [thread overview]
Message-ID: <20191025235031.14635-1-matthew.d.roper@intel.com> (raw)
This test currently does two separate asserts to ensure that
hdisplay > 1024 and vdisplay > 768 to ensure that we're not running on a
system with a native 10x7 panel. However the second assert here will
also fail on 13x7 panels, even though the panel fitter would have been
used in that case. Combine the two tests to make sure we're checking
for exactly the 10x7 mode.
Also, if the assumption that no platform with LPSP would ever have a
10x7 panel turns out to be false, we should just skip this subtest
rather than failing it, so change the igt_assert() to igt_require.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106602
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
tests/i915/i915_pm_lpsp.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
index 42938e10..a1ade58d 100644
--- a/tests/i915/i915_pm_lpsp.c
+++ b/tests/i915/i915_pm_lpsp.c
@@ -109,10 +109,9 @@ static void edp_subtest(int drm_fd, drmModeResPtr drm_res,
* support LPSP are too new for panels with native
* 1024x768 resolution, so this should force the panel
* fitter. */
- igt_assert(c->count_modes &&
- c->modes[0].hdisplay > 1024);
- igt_assert(c->count_modes &&
- c->modes[0].vdisplay > 768);
+ igt_require(c->count_modes &&
+ (c->modes[0].hdisplay != 1024 ||
+ c->modes[0].vdisplay != 768));
mode = &std_1024_mode;
break;
}
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-10-25 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 23:50 Matt Roper [this message]
2019-10-26 0:36 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915_pm_lpsp: Don't always fail pfit subtest on 13x7 panels (rev2) Patchwork
2019-10-27 19:53 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-08-29 17:16 [igt-dev] [PATCH i-g-t] tests/i915_pm_lpsp: Don't always fail pfit subtest on 13x7 panels Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025235031.14635-1-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox