From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 26 Oct 2019 20:39:23 +0300 From: Andi Shyti Message-ID: <20191026173923.GA10452@intel.intel> References: <20191025142333.11806-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191025142333.11806-1-chris@chris-wilson.co.uk> Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915: Use explicit iterator names in for_each_engine() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-ID: SGkgQ2hyaXMsCgpJIHRob3VnaHQgd2Ugd2FudGVkIHRvIGtlZXAgdGhlIHdhcm5pbmdzIGFzIGEg cmVtaW5kZXIgdW50aWwgd2UKcmVtb3ZlZCB0aGUgbGVnYWN5IGZvcmVhY2ggOikKClsuLi5dCgo+ IGRpZmYgLS1naXQgYS9saWIvaWd0X2d0LmggYi9saWIvaWd0X2d0LmgKPiBpbmRleCA3M2I1MDAy YTAuLjY2MDg4ZDM5MSAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2d0LmgKPiArKysgYi9saWIvaWd0 X2d0LmgKPiBAQCAtNzIsMTkgKzcyLDIxIEBAIGV4dGVybiBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhl Y3V0aW9uX2VuZ2luZSB7Cj4gIAl1bnNpZ25lZCBmbGFnczsKPiAgfSBpbnRlbF9leGVjdXRpb25f ZW5naW5lc1tdOwo+ICAKPiArI2RlZmluZSBlYl9yaW5nKGUpICgoZSktPmV4ZWNfaWQgfCAoZSkt PmZsYWdzKQo+ICsKPiAgI2RlZmluZSBmb3JfaWYoZXhwcl9fKSBpZiAoIShleHByX18pKSB7fSBl bHNlCj4gIAo+IC0jZGVmaW5lIGZvcl9lYWNoX2VuZ2luZShmZF9fLCBmbGFnc19fKSBcCj4gLQlm b3IgKGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lICplX18gPSBpbnRlbF9leGVj dXRpb25fZW5naW5lcztcCj4gLQkgICAgIGVfXy0+bmFtZTsgXAo+IC0JICAgICBlX18rKykgXAo+ IC0JCWZvcl9pZiAoZ2VtX2hhc19yaW5nKGZkX18sIGZsYWdzX18gPSBlX18tPmV4ZWNfaWQgfCBl X18tPmZsYWdzKSkKPiAtCj4gLSNkZWZpbmUgZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lKGZkX18s IGZsYWdzX18pIFwKPiAtCWZvciAoY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUg KmVfXyA9IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzO1wKPiAtCSAgICAgZV9fLT5uYW1lOyBcCj4g LQkgICAgIGVfXysrKSBcCj4gLQkJZm9yX2lmIChnZW1fcmluZ19oYXNfcGh5c2ljYWxfZW5naW5l KGZkX18sIGZsYWdzX18gPSBlX18tPmV4ZWNfaWQgfCBlX18tPmZsYWdzKSkKPiArI2RlZmluZSBm b3JfZWFjaF9lbmdpbmUoaXRfXywgZmRfXykgXAo+ICsJZm9yIChjb25zdCBzdHJ1Y3QgaW50ZWxf ZXhlY3V0aW9uX2VuZ2luZSAqaXRfXyA9IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzO1wKPiArCSAg ICAgaXRfXy0+bmFtZTsgXAo+ICsJICAgICBpdF9fKyspIFwKPiArCQlmb3JfaWYgKGdlbV9oYXNf cmluZyhmZF9fLCBlYl9yaW5nKGl0X18pKSkKPiArCj4gKyNkZWZpbmUgZm9yX2VhY2hfcGh5c2lj YWxfZW5naW5lKGl0X18sIGZkX18pIFwKPiArCWZvciAoY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1 dGlvbl9lbmdpbmUgKml0X18gPSBpbnRlbF9leGVjdXRpb25fZW5naW5lcztcCj4gKwkgICAgIGl0 X18tPm5hbWU7IFwKPiArCSAgICAgaXRfXysrKSBcCj4gKwkJZm9yX2lmIChnZW1fcmluZ19oYXNf cGh5c2ljYWxfZW5naW5lKGZkX18sIGViX3JpbmcoaXRfXykpKQoKKHdlIGFscmVhZHkgdGFsa2Vk IG9uY2UgYWJvdXQgdGhpcykgaXQgbWFrZXMgbW9yZSBzZW5zZSB0byBtZSB0aGUKaXRlcmF0b3Ig dG8gYmUgZGVjbGFyZWQgb3V0c2lkZSB0aGUgZnJvbSBsb29wIGluIG9yZGVyIHRvIG5vdCBrZWVw Cml0IGhpZGRlbiBmcm9tIHRoZSB1c2VyLgoKSXQncyBhbHNvIHRvIGJlIGNvbnNpc3RlbnQgd2l0 aCBhbGwgdGhlIHJlc3Qgb2YgdGhlIGl0ZXJhdGlvbnMsCnN0YXJ0aW5nIGZyb20gdGhlICdmb3Io KScuCgpOZXZlcnRoZWxlc3MsIEkgdGhpbmsgdGhpcyBjb2RlIGlzIGdvaW5nIHRvIGRpc2FwcGVh ciBzb21lZGF5cywKc28gdGhhdDoKCkFja2VkLWJ5OiBBbmRpIFNoeXRpIDxhbmRpLnNoeXRpQGlu dGVsLmNvbT4KClRoYW5rcywKQW5kaQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ln dC1kZXY=