From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, Brian Welty <brian.welty@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/rendercopy: Add AUX page table support
Date: Mon, 4 Nov 2019 16:47:21 +0200 [thread overview]
Message-ID: <20191104144721.GB883@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <157286704378.4041.16174637084826801331@skylake-alporthouse-com>
On Mon, Nov 04, 2019 at 11:30:43AM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2019-11-01 20:13:09)
> > +static drm_intel_bo *
> > +gen12_create_aux_pgtable_bo(drm_intel_bufmgr *bufmgr,
> > + const struct igt_buf *dst_buf,
> > + const struct igt_buf *src_buf)
> > +{
> > + struct igt_aux_pgtable_range ranges[2];
> > + int range_count;
> > + uint64_t pin_offset;
> > + drm_intel_bo *gem_bo;
> > +
> > + range_count = 0;
> > + pin_offset = 0;
> > +
> > + range_count += add_aux_pgtable_range(dst_buf,
> > + &ranges[range_count], &pin_offset);
> > + range_count += add_aux_pgtable_range(src_buf,
> > + &ranges[range_count], &pin_offset);
> > +
> > + if (!range_count)
> > + return NULL;
>
> So every batch uses the same locations for their pair of surfaces;
> causing a complete eviction stall between each batch. That's a nasty
> side-effect that will hide flushing bugs between batches.
Ok. As discussed on IRC I'll randomize the offset for either object with
a 0 bo->offset64.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-11-04 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 20:13 [igt-dev] [PATCH i-g-t 1/3] lib/rendercopy: Add AUX page table support Imre Deak
2019-11-01 20:13 ` [igt-dev] [PATCH i-g-t 2/3] tests/gem_render_copy: Adjust the tgl+ compressed buf alignments Imre Deak
2019-11-01 20:13 ` [igt-dev] [PATCH i-g-t 3/3] tests/gem_render_copy: Add compressed src to compressed dst subtests Imre Deak
2019-11-01 21:19 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/3] lib/rendercopy: Add AUX page table support Patchwork
2019-11-01 21:41 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-11-04 11:28 ` [igt-dev] [PATCH i-g-t 1/3] " Chris Wilson
2019-11-04 14:07 ` Imre Deak
2019-11-04 11:30 ` Chris Wilson
2019-11-04 14:47 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104144721.GB883@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=brian.welty@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox