Re: [igt-dev] [PATCH i-g-t 8/8] i915/gem_exec_basic: Use dynamic subtests

[Katarzyna Dec <katarzyna.dec@intel.com>]

On Thu, Oct 24, 2019 at 02:05:46PM +0300, Petri Latvala wrote:
> Instead of generating a subtest for each engine in a static list,
> convert to dynamic subtests, with one dynamic subtest per actually
> present physical engine.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  tests/i915/gem_exec_basic.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 1287860b..b2d6ddc2 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -159,13 +159,25 @@ igt_main
>  	igt_subtest("gtt-all")
>  		gtt_all(fd);
>  
> -	__for_each_physical_engine(fd, e) {
> -		igt_subtest_f("basic-%s", e->name)
> -			noop(fd, e->flags);
> -		igt_subtest_f("readonly-%s", e->name)
> -			readonly(fd, e->flags);
> -		igt_subtest_f("gtt-%s", e->name)
> -			gtt(fd, e->flags);
> +	igt_subtest_with_dynamic_subsubtests("basic") {
> +		__for_each_physical_engine(fd, e) {
> +			igt_dynamic_subsubtest_f("%s", e->name)
> +				noop(fd, e->flags);
> +		}
> +	}
> +
> +	igt_subtest_with_dynamic_subsubtests("readonly") {
> +		__for_each_physical_engine(fd, e) {
> +			igt_dynamic_subsubtest_f("%s", e->name)
> +				readonly(fd, e->flags);
> +		}
> +	}
> +
> +	igt_subtest_with_dynamic_subsubtests("gtt") {
> +		__for_each_physical_engine(fd, e) {
> +			igt_dynamic_subsubtest_f("%s", e->name)
> +				gtt(fd, e->flags);
> +		}
>  	}
>  
>  	igt_fixture {
> -- 
> 2.19.1
>
LGTM :)
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev