[igt-dev] [PATCH i-g-t] tests/igt_command_line.sh: Log what went wrong

[Arkadiusz Hiler <arkadiusz.hiler@intel.com>]

The following error looks quite mysterious:

   $ ../../tests/igt_command_line.sh kms_ccs
   ./kms_ccs:
     Checking invalid option handling...
     Checking valid option handling...
     Checking subtest enumeration...
   FAIL: ./kms_ccs

Let's add some explanation when we fail the subtests enumeration checks
so people are not completely baffled when they get failures from the CI.

Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/igt_command_line.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh
index a019e3a5..291b6526 100755
--- a/tests/igt_command_line.sh
+++ b/tests/igt_command_line.sh
@@ -79,10 +79,12 @@ check_test ()
 	LIST=`./$test --list-subtests`
 	RET=$?
 	if [ $RET -ne 0 -a $RET -ne 79 ]; then
+		echo "    test does not exit with 0 or 79 with --list-subtests!"
 		fail $test
 	fi
 
 	if [ $RET -eq 79 -a -n "$LIST" ]; then
+		echo "    test seems to be using igt_simple_main() (no subtests) and yet --list-subtests is NOT empty!"
 		fail $test
 	fi
 
@@ -91,6 +93,7 @@ check_test ()
 		# on the running kernel. If selftests are not enabled,
 		# they will output nothing and exit with 0.
 		if [ "$testname" != "i915_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" -a "$testname" != "dmabuf" ]; then
+			echo "    test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!"
 			fail $test
 		fi
 	fi
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev