public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/tools_test: Add extra logging around chdirs
Date: Tue, 12 Nov 2019 18:40:12 +0200	[thread overview]
Message-ID: <20191112164012.463634-1-arkadiusz.hiler@intel.com> (raw)

Sometimes we end up in /bin and I am not able to explain that just by
looking at the machine or the IGT tarball that was deployed there so
let's get some more breadcrumbs.

Cc: Petri Latvala <petri.latvala@intel.com>
Issue: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/12
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/tools_test.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/tests/tools_test.c b/tests/tools_test.c
index 88a6ae96..e3f73ac2 100644
--- a/tests/tools_test.c
+++ b/tests/tools_test.c
@@ -63,14 +63,30 @@ static void assert_cmd_success(int exec_return)
 static bool chdir_to_tools_dir(void)
 {
 	char path[PATH_MAX];
+	char *cwd;
+
+	cwd = get_current_dir_name();
+	igt_info("Current working directory: %s\n", cwd);
+	free(cwd);
 
 	/* Try TOOLS relative to cwd */
+	igt_info("Trying to cd to %s\n", TOOLS);
 	if (chdir(TOOLS) == 0)
 		return true;
 
+	igt_info("Failed to cd to %s\n", TOOLS);
+
 	/* Try TOOLS and install dir relative to test binary */
-	if (readlink("/proc/self/exe", path, sizeof(path)) > 0)
+	if (readlink("/proc/self/exe", path, sizeof(path)) > 0) {
+		igt_info("/proc/self/exe point to %s, going to dirname()\n", path);
 		chdir(dirname(path));
+	}
+
+	cwd = get_current_dir_name();
+	igt_info("Current working directory: %s\n", cwd);
+	free(cwd);
+
+	igt_info("Trying to cd to %s or ../../bin\n", TOOLS);
 
 	return chdir(TOOLS) == 0 || chdir("../../bin") == 0;
 }
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-11-12 16:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 16:40 Arkadiusz Hiler [this message]
2019-11-12 18:37 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/tools_test: Add extra logging around chdirs Patchwork
2019-11-13  3:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-11-13  8:09 ` [igt-dev] [PATCH i-g-t] " Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112164012.463634-1-arkadiusz.hiler@intel.com \
    --to=arkadiusz.hiler@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox