public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Jeevan B <jeevan.b@intel.com>
Subject: [igt-dev] [PATCH i-g-t 3/4] tests/i915_pm_dc: Simplify runtime pm handling
Date: Wed, 13 Nov 2019 14:39:30 -0800	[thread overview]
Message-ID: <20191113223931.174701-3-jose.souza@intel.com> (raw)
In-Reply-To: <20191113223931.174701-1-jose.souza@intel.com>

has_runtime_pm was not used outside of igt_fixture also no need to
print this info, if not supported IGT skip log will contain the line
that was not meet.

Cc: Jeevan B <jeevan.b@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/i915/i915_pm_dc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index d241ed16..da4d66a7 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -390,7 +390,6 @@ static void test_dc_state_dpms(data_t *data, int dc_flag)
 IGT_TEST_DESCRIPTION("These tests validate Display Power DC states");
 int main(int argc, char *argv[])
 {
-	bool has_runtime_pm;
 	data_t data = {};
 
 	igt_skip_on_simulation();
@@ -402,9 +401,7 @@ int main(int argc, char *argv[])
 		kmstest_set_vt_graphics_mode();
 		data.devid = intel_get_drm_devid(data.drm_fd);
 		igt_pm_enable_sata_link_power_management();
-		has_runtime_pm = igt_setup_runtime_pm();
-		igt_info("Runtime PM support: %d\n", has_runtime_pm);
-		igt_require(has_runtime_pm);
+		igt_require(igt_setup_runtime_pm());
 		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
 		igt_display_require(&data.display, data.drm_fd);
 		igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_2));
-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-11-13 22:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 22:39 [igt-dev] [PATCH i-g-t 1/4] lib/igt_psr: Unset errno when expected José Roberto de Souza
2019-11-13 22:39 ` [igt-dev] [PATCH i-g-t 2/4] tests/i915_pm_dc: Use psr_sink_support of reimplement it again José Roberto de Souza
2019-11-13 22:39 ` José Roberto de Souza [this message]
2019-11-14  8:09   ` [igt-dev] [PATCH i-g-t 3/4] tests/i915_pm_dc: Simplify runtime pm handling Arkadiusz Hiler
2019-11-13 22:39 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_psr: Move "is enabled" implementation to lib José Roberto de Souza
2019-11-14  1:46 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_psr: Unset errno when expected Patchwork
2019-11-14 22:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113223931.174701-3-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox