From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 369A96EE9C for ; Thu, 14 Nov 2019 18:20:58 +0000 (UTC) Date: Thu, 14 Nov 2019 20:19:06 +0200 From: Imre Deak Message-ID: <20191114181906.GB13793@ideak-desk.fi.intel.com> References: <20191114094403.19908-1-mika.kahola@kolumbus.fi> <20191114094403.19908-3-mika.kahola@kolumbus.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191114094403.19908-3-mika.kahola@kolumbus.fi> Subject: Re: [igt-dev] [PATCH v6 2/3] lib/igt_fb.c: Update tile sizes for GEN12 CCS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Mika Kahola Cc: igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCBOb3YgMTQsIDIwMTkgYXQgMTE6NDQ6MDJBTSArMDIwMCwgTWlrYSBLYWhvbGEgd3Jv dGU6Cj4gRnJvbTogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVsLmNvbT4KPiAKPiBVcGRh dGUgdGlsZSBzaXplcyBmb3IgR0VOMTIgQ0NTLgo+IAo+IEJTcGVjOiA0NzcwOQo+IAo+IHYyOiBS ZWFsaWduIG1haW4gYW5kIGF1eCBzdXJmYWNlcyAoSW1yZSkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBN aWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUg RGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cgo+IC0tLQo+ICBsaWIvaWd0X2ZiLmMgfCA1MCArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg NDMgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2ln dF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXggNGFkY2E5NjcuLjFkMWUwZDIyIDEwMDY0NAo+ IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3RfZmIuYwo+IEBAIC00MDEsNiArNDAx LDcgQEAgdm9pZCBpZ3RfZ2V0X2ZiX3RpbGVfc2l6ZShpbnQgZmQsIHVpbnQ2NF90IG1vZGlmaWVy LCBpbnQgZmJfYnBwLAo+ICAJCWJyZWFrOwo+ICAJY2FzZSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0Rf WV9USUxFRDoKPiAgCWNhc2UgTE9DQUxfSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfQ0NTOgo+ICsJ Y2FzZSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9HRU4xMl9SQ19DQ1M6Cj4gIAkJaWd0 X3JlcXVpcmVfaW50ZWwoZmQpOwo+ICAJCWlmIChpbnRlbF9nZW4oaW50ZWxfZ2V0X2RybV9kZXZp ZChmZCkpID09IDIpIHsKPiAgCQkJKndpZHRoX3JldCA9IDEyODsKPiBAQCAtNDY1LDE4ICs0NjYs MzAgQEAgdm9pZCBpZ3RfZ2V0X2ZiX3RpbGVfc2l6ZShpbnQgZmQsIHVpbnQ2NF90IG1vZGlmaWVy LCBpbnQgZmJfYnBwLAo+ICAJfQo+ICB9Cj4gIAo+ICtzdGF0aWMgYm9vbCBpc19nZW4xMl9jY3Nf bW9kaWZpZXIodWludDY0X3QgbW9kaWZpZXIpCj4gK3sKPiArCXJldHVybiBtb2RpZmllciA9PSBJ OTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9HRU4xMl9SQ19DQ1M7Cj4gK30KPiArCj4gIHN0YXRpYyBi b29sIGlzX2Njc19tb2RpZmllcih1aW50NjRfdCBtb2RpZmllcikKPiAgewo+IC0JcmV0dXJuIG1v ZGlmaWVyID09IExPQ0FMX0k5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUyB8fAo+IC0JCW1vZGlm aWVyID09IExPQ0FMX0k5MTVfRk9STUFUX01PRF9ZZl9USUxFRF9DQ1M7Cj4gKwo+ICsJcmV0dXJu IGlzX2dlbjEyX2Njc19tb2RpZmllcihtb2RpZmllcikgfHwKPiArCQltb2RpZmllciA9PSBJOTE1 X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1MgfHwKPiArCQltb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9N T0RfWWZfVElMRURfQ0NTOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVfd2lk dGgoY29uc3Qgc3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiAgewo+ICAJY29uc3Qgc3Ry dWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0ID0gbG9va3VwX2RybV9mb3JtYXQoZmItPmRy bV9mb3JtYXQpOwo+ICAKPiAtCWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVyKSAmJiBw bGFuZSA9PSAxKQo+IC0JCXJldHVybiBESVZfUk9VTkRfVVAoZmItPndpZHRoLCAxMDI0KSAqIDEy ODsKPiArCWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVyKSAmJiBwbGFuZSA9PSAxKSB7 Cj4gKwkJaWYgKGlzX2dlbjEyX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpKQo+ICsJCQlyZXR1 cm4gRElWX1JPVU5EX1VQKGZiLT53aWR0aCwKPiArCQkJCQkgICAgNTEyIC8gKGZiLT5wbGFuZV9i cHBbMF0gLyA4KSkgKiA2NDsKPiArCQllbHNlCj4gKwkJCXJldHVybiBESVZfUk9VTkRfVVAoZmIt PndpZHRoLCAxMDI0KSAqIDEyODsKPiArCX0KPiAgCj4gIAlpZiAocGxhbmUgPT0gMCkKPiAgCQly ZXR1cm4gZmItPndpZHRoOwo+IEBAIC00OTgsOCArNTExLDEyIEBAIHN0YXRpYyB1bnNpZ25lZCBm Yl9wbGFuZV9oZWlnaHQoY29uc3Qgc3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiAgewo+ ICAJY29uc3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0ID0gbG9va3VwX2RybV9m b3JtYXQoZmItPmRybV9mb3JtYXQpOwo+ICAKPiAtCWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1v ZGlmaWVyKSAmJiBwbGFuZSA9PSAxKQo+IC0JCXJldHVybiBESVZfUk9VTkRfVVAoZmItPmhlaWdo dCwgNTEyKSAqIDMyOwo+ICsJaWYgKGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpICYmIHBs YW5lID09IDEpIHsKPiArCQlpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZiLT5tb2RpZmllcikp Cj4gKwkJCXJldHVybiBESVZfUk9VTkRfVVAoZmItPmhlaWdodCwgMTI4KSAqIDQ7Cj4gKwkJZWxz ZQo+ICsJCQlyZXR1cm4gRElWX1JPVU5EX1VQKGZiLT5oZWlnaHQsIDUxMikgKiAzMjsKPiArCX0K PiAgCj4gIAlpZiAocGxhbmUgPT0gMCkKPiAgCQlyZXR1cm4gZmItPmhlaWdodDsKPiBAQCAtNTcy LDEyICs1ODksMTggQEAgc3RhdGljIHVpbnQzMl90IGNhbGNfcGxhbmVfc3RyaWRlKHN0cnVjdCBp Z3RfZmIgKmZiLCBpbnQgcGxhbmUpCj4gIAkJICogc28gdGhlIGVhc2llc3Qgd2F5IGlzIHRvIGFs aWduIHRoZSBsdW1hIHN0cmlkZSB0byAyNTYuCj4gIAkJICovCj4gIAkJcmV0dXJuIEFMSUdOKG1p bl9zdHJpZGUsIDI1Nik7Cj4gKwl9IGVsc2UgaWYgKGlzX2dlbjEyX2Njc19tb2RpZmllcihmYi0+ bW9kaWZpZXIpICYmIHBsYW5lID09IDEpIHsKPiArCQkvKiBBIG1haW4gc3VyZmFjZSB1c2luZyBh IENDUyBBVVggc3VyZmFjZSBtdXN0IGJlIDR4NCB0aWxlcyBhbGlnbmVkLiAqLwo+ICsJCXJldHVy biBBTElHTihtaW5fc3RyaWRlLCA2NCk7Cj4gIAl9IGVsc2Ugewo+ICAJCXVuc2lnbmVkIGludCB0 aWxlX3dpZHRoLCB0aWxlX2hlaWdodDsKPiAgCj4gIAkJaWd0X2dldF9mYl90aWxlX3NpemUoZmIt PmZkLCBmYi0+bW9kaWZpZXIsIGZiLT5wbGFuZV9icHBbcGxhbmVdLAo+ICAJCQkJICAgICAmdGls ZV93aWR0aCwgJnRpbGVfaGVpZ2h0KTsKPiAgCj4gKwkJaWYgKGlzX2dlbjEyX2Njc19tb2RpZmll cihmYi0+bW9kaWZpZXIpKQo+ICsJCQl0aWxlX3dpZHRoICo9IDQ7Cj4gKwo+ICAJCXJldHVybiBB TElHTihtaW5fc3RyaWRlLCB0aWxlX3dpZHRoKTsKPiAgCX0KPiAgfQo+IEBAIC02MDMsMTIgKzYy NiwyMCBAQCBzdGF0aWMgdWludDY0X3QgY2FsY19wbGFuZV9zaXplKHN0cnVjdCBpZ3RfZmIgKmZi LCBpbnQgcGxhbmUpCj4gIAkJc2l6ZSA9IHJvdW5kdXBfcG93ZXJfb2ZfdHdvKHNpemUpOwo+ICAK PiAgCQlyZXR1cm4gc2l6ZTsKPiArCX0gZWxzZSBpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZi LT5tb2RpZmllcikgJiYgcGxhbmUgPT0gMSkgewo+ICsJCS8qIFRoZSBBVVggQ0NTIHN1cmZhY2Ug bXVzdCBiZSBwYWdlIGFsaWduZWQgKi8KPiArCQlyZXR1cm4gKHVpbnQ2NF90KWZiLT5zdHJpZGVz W3BsYW5lXSAqCj4gKwkJCUFMSUdOKGZiLT5wbGFuZV9oZWlnaHRbcGxhbmVdLCA2NCk7Cj4gIAl9 IGVsc2Ugewo+ICAJCXVuc2lnbmVkIGludCB0aWxlX3dpZHRoLCB0aWxlX2hlaWdodDsKPiAgCj4g IAkJaWd0X2dldF9mYl90aWxlX3NpemUoZmItPmZkLCBmYi0+bW9kaWZpZXIsIGZiLT5wbGFuZV9i cHBbcGxhbmVdLAo+ICAJCQkJICAgICAmdGlsZV93aWR0aCwgJnRpbGVfaGVpZ2h0KTsKPiAgCj4g KwkJLyogQSBtYWluIHN1cmZhY2UgdXNpbmcgYSBDQ1MgQVVYIHN1cmZhY2UgbXVzdCBiZSA0eDQg dGlsZXMgYWxpZ25lZC4gKi8KPiArCQlpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZiLT5tb2Rp ZmllcikpCj4gKwkJCXRpbGVfaGVpZ2h0ICo9IDQ7Cj4gKwo+ICAJCS8qIFNwZWNpYWwgY2FzZSB3 aGVyZSB0aGUgInRpbGUgaGVpZ2h0IiByZXByZXNlbnRzIGEKPiAgCQkgKiBoZWlnaHQtYmFzZWQg c3RyaWRlLCBzdWNoIGFzIHdpdGggVkM0IFNBTkQgdGlsaW5nIG1vZGVzLgo+ICAJCSAqLwo+IEBA IC02ODcsNiArNzE4LDcgQEAgdWludDY0X3QgaWd0X2ZiX21vZF90b190aWxpbmcodWludDY0X3Qg bW9kaWZpZXIpCj4gIAkJcmV0dXJuIEk5MTVfVElMSU5HX1g7Cj4gIAljYXNlIExPQ0FMX0k5MTVf Rk9STUFUX01PRF9ZX1RJTEVEOgo+ICAJY2FzZSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0RfWV9USUxF RF9DQ1M6Cj4gKwljYXNlIExPQ0FMX0k5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0dFTjEyX1JDX0ND UzoKPiAgCQlyZXR1cm4gSTkxNV9USUxJTkdfWTsKPiAgCWNhc2UgTE9DQUxfSTkxNV9GT1JNQVRf TU9EX1lmX1RJTEVEOgo+ICAJY2FzZSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0RfWWZfVElMRURfQ0NT Ogo+IEBAIC0xODk1LDcgKzE5MjcsMTEgQEAgc3RhdGljIHZvaWQgaW5pdF9idWYoc3RydWN0IGZi X2JsaXRfdXBsb2FkICpibGl0LAo+ICAKPiAgCWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1vZGlm aWVyKSkgewo+ICAJCWlndF9hc3NlcnRfZXEoZmItPnN0cmlkZXNbMF0gJiAxMjcsIDApOwo+IC0J CWlndF9hc3NlcnRfZXEoZmItPnN0cmlkZXNbMV0gJiAxMjcsIDApOwo+ICsKPiArCQlpZiAoaXNf Z2VuMTJfY2NzX21vZGlmaWVyKGZiLT5tb2RpZmllcikpCj4gKwkJCWlndF9hc3NlcnRfZXEoZmIt PnN0cmlkZXNbMV0gJiA2MywgMCk7Cj4gKwkJZWxzZQo+ICsJCQlpZ3RfYXNzZXJ0X2VxKGZiLT5z dHJpZGVzWzFdICYgMTI3LCAwKTsKPiAgCj4gIAkJYnVmLT5hdXgub2Zmc2V0ID0gZmItPm9mZnNl dHNbMV07Cj4gIAkJYnVmLT5hdXguc3RyaWRlID0gZmItPnN0cmlkZXNbMV07Cj4gLS0gCj4gMi4x Ny4xCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmln dC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==