From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Jeevan B <jeevan.b@intel.com>
Subject: [igt-dev] [PATCH i-g-t CI 2/4] tests/i915_pm_dc: Use psr_sink_support instead of reimplement it again
Date: Thu, 14 Nov 2019 14:45:22 -0800 [thread overview]
Message-ID: <20191114224524.175852-2-jose.souza@intel.com> (raw)
In-Reply-To: <20191114224524.175852-1-jose.souza@intel.com>
Also moving the sink check to igt_fixture as it do not change
overtime.
Cc: Jeevan B <jeevan.b@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
tests/i915/i915_pm_dc.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index f7a3896b..de3c8722 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -84,16 +84,6 @@ static void display_fini(data_t *data)
igt_display_fini(&data->display);
}
-static bool edp_psr_sink_support(data_t *data)
-{
- char buf[512];
-
- igt_debugfs_simple_read(data->debugfs_fd, "i915_edp_psr_status",
- buf, sizeof(buf));
-
- return strstr(buf, "Sink support: yes");
-}
-
static bool edp_psr2_enabled(data_t *data)
{
char buf[512];
@@ -417,6 +407,7 @@ int main(int argc, char *argv[])
igt_require(has_runtime_pm);
igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
igt_display_require(&data.display, data.drm_fd);
+ igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
/* Make sure our Kernel supports MSR and the module is loaded */
igt_require(igt_kmod_load("msr", NULL) == 0);
@@ -436,8 +427,6 @@ int main(int argc, char *argv[])
igt_subtest("dc5-psr") {
data.op_psr_mode = PSR_MODE_1;
psr_enable(data.debugfs_fd, data.op_psr_mode);
- igt_require_f(edp_psr_sink_support(&data),
- "Sink does not support PSR\n");
test_dc_state_psr(&data, CHECK_DC5);
}
@@ -446,8 +435,6 @@ int main(int argc, char *argv[])
igt_subtest("dc6-psr") {
data.op_psr_mode = PSR_MODE_1;
psr_enable(data.debugfs_fd, data.op_psr_mode);
- igt_require_f(edp_psr_sink_support(&data),
- "Sink does not support PSR\n");
igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
"PC8+ residencies not supported\n");
test_dc_state_psr(&data, CHECK_DC6);
--
2.24.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-11-14 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 22:45 [igt-dev] [PATCH i-g-t CI 1/4] lib/igt_psr: Unset errno when expected José Roberto de Souza
2019-11-14 22:45 ` José Roberto de Souza [this message]
2019-11-14 22:45 ` [igt-dev] [PATCH i-g-t CI 3/4] tests/i915_pm_dc: Simplify runtime pm handling José Roberto de Souza
2019-11-14 22:45 ` [igt-dev] [PATCH i-g-t CI 4/4] lib/igt_psr: Move "is enabled" implementation to lib José Roberto de Souza
2019-11-14 23:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,CI,1/4] lib/igt_psr: Unset errno when expected Patchwork
2019-11-15 8:31 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-11-16 5:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-11-18 18:18 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114224524.175852-2-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox