Re: [igt-dev] [PATCH i-g-t v2 1/4] lib/i915/gem_mman: add mmap_offset support

Zbigniew Kempczyński
2019-11-19T17:20:01Z

On Tue, Nov 19, 2019 at 05:23:09PM +0100, Summers, Stuart wrote:

> Chris mentioned this in a patch I had posted over the weekend, but this
> isn't going to properly support the legacy platforms which don't have
> IOCTL versioning.
>
> What if we pull has_gtt_mmap() in from tests/i915/gem_userptr_blits.c,
> and make it a test we can use across the different tests that need it.
> I did test this locally and it seems to work, although I haven't done a
> full regression.
>
> IMO this can also be separated out in a new patch, since it isn't
> specifically required for the mmap_offset changes here.
>

Ok, understand. I'm going to remove this function then and if you
have code already tested (taken from gem_userptr_blits) please send
it in another patch.

Thanks for comments.
Zbigniew