From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: "Summers, Stuart" <stuart.summers@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v2 1/4] lib/i915/gem_mman: add mmap_offset support
Date: Tue, 19 Nov 2019 18:19:59 +0100 [thread overview]
Message-ID: <20191119171959.GA28080@zkempczy-mobl2> (raw)
In-Reply-To: <3264b32d24d2af78abcebe16d4858d611b4bb045.camel@intel.com>
On Tue, Nov 19, 2019 at 05:23:09PM +0100, Summers, Stuart wrote:
> Chris mentioned this in a patch I had posted over the weekend, but this
> isn't going to properly support the legacy platforms which don't have
> IOCTL versioning.
>
> What if we pull has_gtt_mmap() in from tests/i915/gem_userptr_blits.c,
> and make it a test we can use across the different tests that need it.
> I did test this locally and it seems to work, although I haven't done a
> full regression.
>
> IMO this can also be separated out in a new patch, since it isn't
> specifically required for the mmap_offset changes here.
>
Ok, understand. I'm going to remove this function then and if you
have code already tested (taken from gem_userptr_blits) please send
it in another patch.
Thanks for comments.
Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-11-19 17:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 16:02 [igt-dev] [PATCH i-g-t v2 0/4] Basic LMEM support in IGT Zbigniew Kempczyński
2019-11-19 16:02 ` [igt-dev] [PATCH i-g-t v2 1/4] lib/i915/gem_mman: add mmap_offset support Zbigniew Kempczyński
2019-11-19 16:23 ` Summers, Stuart
2019-11-19 17:19 ` Zbigniew Kempczyński [this message]
2019-11-19 16:02 ` [igt-dev] [PATCH i-g-t v2 2/4] lib/i915/intel_memory_region: Add lib to manage memory regions Zbigniew Kempczyński
2019-11-19 18:03 ` Vanshidhar Konda
2019-11-20 7:20 ` Zbigniew Kempczyński
2019-11-20 9:34 ` Petri Latvala
2019-11-20 16:27 ` Zbigniew Kempczyński
2019-11-19 16:02 ` [igt-dev] [PATCH i-g-t v2 3/4] tests/i915/gem_mmap_offset: Add new API test for gem_mmap_offset Zbigniew Kempczyński
2019-11-19 18:13 ` Vanshidhar Konda
2019-11-20 10:50 ` Zbigniew Kempczyński
2019-11-19 16:02 ` [igt-dev] [PATCH i-g-t v2 4/4] tests/i915/gem_exec_basic: Iterate over all memory regions Zbigniew Kempczyński
2019-11-19 18:15 ` Vanshidhar Konda
2019-11-19 16:53 ` [igt-dev] ✗ GitLab.Pipeline: warning for Basic LMEM support in IGT (rev2) Patchwork
2019-11-19 17:00 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119171959.GA28080@zkempczy-mobl2 \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=stuart.summers@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox