From: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, andi.shyti@intel.com
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
Date: Tue, 19 Nov 2019 10:47:02 -0800 [thread overview]
Message-ID: <20191119184701.GA15588@intel.com> (raw)
In-Reply-To: <157416338013.10169.9033467622461448226@skylake-alporthouse-com>
On 19/11/19 11:36, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
> >
> > On 19/11/2019 11:11, Chris Wilson wrote:
> > > Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> > >> Since engines are now looked up based on context engine map,
> > >> context should be setup with engines before using in execbuf.
> > >
> > > Stop changing fundamental tests of legacy behaviour. If you want to
> > > exercise new API, do so in parallel.
> >
> > The test is already using the new api so as it stands there's a mismatch
> > on engine flags and context - since it passes the engine flags to the
> > thread, derived from a context with engine map, but the thread uses a
> > legacy context. It has to be aligned for the intended engine to get
> > exercised.
>
> Then consider it a retrospective complaint for mucking up a basic test :-p
I've added Andy to thread(owner of orginal patch series). I'm wondering if we
should review the all tests which are adopted to use new API only and
have both legacy and new behaviour.
~Sandeep.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-11-19 18:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 11:01 [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map Venkata Sandeep Dhanalakota
2019-11-19 11:01 ` [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: " Venkata Sandeep Dhanalakota
2019-11-19 11:11 ` Chris Wilson
2019-11-19 11:22 ` Tvrtko Ursulin
2019-11-19 11:36 ` Chris Wilson
2019-11-19 18:47 ` Venkata Sandeep Dhanalakota [this message]
2019-11-20 9:13 ` Tvrtko Ursulin
2019-11-20 9:35 ` Chris Wilson
2019-11-20 10:18 ` Tvrtko Ursulin
2019-11-20 15:22 ` Venkata Sandeep Dhanalakota
2019-11-19 11:16 ` Tvrtko Ursulin
2019-11-19 11:08 ` [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: " Chris Wilson
2019-11-19 11:24 ` Tvrtko Ursulin
2019-11-19 11:35 ` Chris Wilson
2019-11-19 11:41 ` Tvrtko Ursulin
2019-11-19 11:15 ` Tvrtko Ursulin
2019-11-19 11:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2019-11-19 16:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119184701.GA15588@intel.com \
--to=venkata.s.dhanalakota@intel.com \
--cc=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox