From: don.hiatt@intel.com
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
Date: Thu, 21 Nov 2019 17:10:36 -0800 [thread overview]
Message-ID: <20191122011036.136424-1-don.hiatt@intel.com> (raw)
From: Don Hiatt <don.hiatt@intel.com>
Suspending to disk requires swap space, make sure it exists
before attempting to suspend to disk.
v2: Use igt_skip() [Thanks, Chris!]
v3: Use igt_skip_on_f()
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
lib/igt_aux.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 578f857933f0..a6b114ed7e65 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
igt_require(test == SUSPEND_TEST_NONE ||
faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
+ igt_skip_on_f(state == SUSPEND_STATE_DISK &&
+ !intel_get_total_swap_mb(),
+ "Suspend to disk requires swap space.\n");
+
orig_test = get_suspend_test(power_dir);
set_suspend_test(power_dir, test);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-11-22 0:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 1:10 don.hiatt [this message]
2019-11-22 1:54 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/aux: Ensure swap space prior to suspend to disk (rev3) Patchwork
2019-11-23 8:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-11-26 0:49 ` [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk Sujaritha
2019-11-26 9:52 ` Petri Latvala
2019-11-26 17:05 ` Hiatt, Don
2019-11-28 13:30 ` Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2019-11-22 1:08 don.hiatt
2019-11-22 0:43 don.hiatt
2019-11-22 0:36 ` Chris Wilson
2019-11-22 0:40 ` Hiatt, Don
2019-11-22 0:52 ` Hiatt, Don
2019-11-22 0:55 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122011036.136424-1-don.hiatt@intel.com \
--to=don.hiatt@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox