From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/rendercopy_gen9: Set rw domains to zero for GEN12
Date: Thu, 28 Nov 2019 12:32:05 +0200 [thread overview]
Message-ID: <20191128103205.GA10209@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <157493258091.31435.13767147710831275412@skylake-alporthouse-com>
On Thu, Nov 28, 2019 at 09:16:20AM +0000, Chris Wilson wrote:
> Quoting Mika Kahola (2019-11-28 09:12:28)
> > GEN12 doesn't need read and write domains to be set. Let's set
> > these to zero in case of GEN12.
>
> Why gen12? For the entire file the only bit that is significant is
> write_domain != 0
Err, that idea was mine, but then it was wrong. Mika needs to add a
relocation on this surface state to the color key data that's where this
change comes from.
Didn't think about the write domain being significant even on LLC
platforms, so let's just drop my idea for now (was only for clarity when
emitting relocations on GEN12) and use the same read/write domains as on
other platforms.
For reference could you explain how the write domain is signicant on LLC
platforms? (My guess now is that the kernel can wait for writes on the
surface to finnish, but it doesn't need it to flush caches, which is not
necessary on LLC.)
Thanks,
Imre
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-11-28 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 9:12 [igt-dev] [PATCH i-g-t] lib/rendercopy_gen9: Set rw domains to zero for GEN12 Mika Kahola
2019-11-28 9:16 ` Chris Wilson
2019-11-28 10:32 ` Imre Deak [this message]
2019-11-28 10:39 ` Chris Wilson
2019-11-28 10:45 ` Kahola, Mika
2019-11-28 10:58 ` Imre Deak
2019-11-28 10:24 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2019-11-28 11:08 ` Petri Latvala
2019-11-28 12:50 ` Arkadiusz Hiler
2019-11-28 10:39 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-11-29 15:14 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128103205.GA10209@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox