public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/gem_render_copy: Add software tiling / detiling support
Date: Fri, 29 Nov 2019 11:46:17 +0100	[thread overview]
Message-ID: <20191129104617.GA8090@zkempczy-mobl2> (raw)
In-Reply-To: <157502242840.14329.16041173636102175191@skylake-alporthouse-com>

On Fri, Nov 29, 2019 at 10:13:48AM +0000, Chris Wilson wrote:
> Quoting Zbigniew Kempczyński (2019-11-29 09:36:53)
> > Older GENs have mmapable GGTT which does buffer tiling / detaling
> > automatically. Newer GENs have looses this possibility so software
> > tiling / detiling is required.
> 
> A bunch of trivial checks to ensure idempotence (i.e linear -> X ->
> linear) with 4K and 2M and a bunch of tiling strides would be useful.
> 
> Note that these functions only correspond to HW detiling when swizzling
> is off -- you can ask the kernel via GET_TILING_IOCTL.
> -Chris

I thought about above check. But this would tie my hands if I would like
to use mix software tiling / hw detiling. Thus I decided to set function
pointers manually according to generation. 

If I good understand you:
You suggest to create single structure (instead of arrays), detect hw
tiling/detiling capabilities for each supported tile (X / Y)
and fill appropriate functions?

But I still need some table containing information about all tile formats
HW supports (for example Yf on Gen9+ even if we can't put it via 
gtt, because it won't tile it in the fly). In this situation I don't 
know is it possible to ask the HW about is it supports Yf format).

Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-11-29 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29  9:36 [igt-dev] [PATCH i-g-t] tests/gem_render_copy: Add software tiling / detiling support Zbigniew Kempczyński
2019-11-29 10:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-11-29 10:13 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-11-29 10:46   ` Zbigniew Kempczyński [this message]
2019-11-30  4:56 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191129104617.GA8090@zkempczy-mobl2 \
    --to=zbigniew.kempczynski@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox